[nexus] Support allocating external IP addresses for internal services#1611
Merged
Conversation
smklein
commented
Aug 17, 2022
smklein
commented
Aug 17, 2022
smklein
commented
Aug 17, 2022
bnaecker
reviewed
Aug 17, 2022
bnaecker
reviewed
Aug 17, 2022
bnaecker
reviewed
Aug 17, 2022
bnaecker
reviewed
Aug 17, 2022
bnaecker
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for finding / fixing the idempotency edge case, and the tests look great! I've got a few questions around constraints and the new IpSource field.
Collaborator
Author
All comments addressed - this should be ready for re-review! |
bnaecker
reviewed
Aug 23, 2022
bnaecker
approved these changes
Aug 23, 2022
bnaecker
left a comment
Collaborator
There was a problem hiding this comment.
Excellent, thanks for taking another pass. Looks great!
smklein
added a commit
that referenced
this pull request
Sep 6, 2022
leftwo
added a commit
that referenced
this pull request
Jan 29, 2025
Crucible changes are: Add early rejection of IOs if too many Downstairs are inactive (#1565) Fix missing write stats in Oximeter. (#1617) Shrink replay buffer (#1616) Update tokio to 1.40 (#1611) Propolis changes are: crates: move host CPUID queries from cpuid-gen to cpuid-utils (#843) --------- Co-authored-by: Alan Hanson <alan@oxide.computer>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the allocation of external IPs to also support "service IPs", which are not associated with instances.
instance_external_iptable to let the project be optional. A "service IP" is one where the project and instance IDs are both "NULL".Part of #1530
Fixes #1610