Don't build docker images in CI#1062
Merged
Merged
Conversation
Contributor
|
not a review, but thank you thank you for doing this! |
david-crespo
added a commit
that referenced
this pull request
Jun 15, 2022
This reverts commit 1e742ff.
david-crespo
added a commit
that referenced
this pull request
Jun 17, 2022
* Revert "don't build docker images in CI (#1062)" This reverts commit 1e742ff. * update readme to mention CLI, not console * the obvious thing would be to use install_prereqs.sh directly, but let's try this instead * give up, attempt to run install_prerequisites.sh * just for fun, remove sudo from install prereqs script * also try copying the install step out of the script, but *before* cargo build * Revert "just for fun, remove sudo from install prereqs script" 5a7503f * use prereqs script again, this time with workarounds * try and fix the branch name extractor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've stopped using it in console (oxidecomputer/console#858) and I'm pretty sure nothing else is using it. Won't merge until I have confirmation of that. This job is not required in CI, so its removal does not prevent PRs from passing.