Get rid of GCP deploy#858
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
Author
|
I talked to @benjaminleonard and @zephraph about this and they both rarely use the GCP thing, instead checking things out locally anyway. So we're gonna do it. |
This was referenced May 12, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a thought. I was curious what this would look like and got far enough to PR it. I don't feel too strongly about doing it, probably want to mull it over.
It would be cool to deploy
yarn start:mswto Vercel (see pro/con in #850), but it probably shouldn't be publicly accessible and it would be annoying to auth gate it on Vercel or put it behind VPN. It's so easy to check out a commit and runyarn && yarn start:mswlocally that I'm losing confidence that the GCP setup is worth maintaining. It was very useful for a while, but we have the mock server for our purposes, and the full stack is being exercised much better elsewhere now.