Skip to content

fix(server): fix closed leader controller panic#668

Merged
merlimat merged 10 commits intomainfrom
fix.panic.nil
Apr 26, 2025
Merged

fix(server): fix closed leader controller panic#668
merlimat merged 10 commits intomainfrom
fix.panic.nil

Conversation

@mattisonchao
Copy link
Copy Markdown
Member

Motivation

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0x1bb6c67]

goroutine 145334082 [running]:
github.com/streamnative/oxia/server.(*leaderController).handleWalSynced(0xc004533b00, {0x2549ec8, 0xc0081e0c00}, 0xc00ce27d80, 0xc00ed2c8c0, 0x754f84, 0x19656309cff, {0x0?, 0x0?}, {0xc00c4397a0, ...})
	/src/oxia/server/leader_controller.go:920 +0x227
github.com/streamnative/oxia/server.(*leaderController).handleWriteStream.func1(0xc0089353b0?, 0x754f84?, {0x0?, 0x0?})
	/src/oxia/server/leader_controller.go:906 +0x72
github.com/streamnative/oxia/server.(*leaderController).appendToWalStreamRequest.func1({0x0?, 0x0?})
	/src/oxia/server/leader_controller.go:984 +0xa2
github.com/streamnative/oxia/server/wal.(*wal).runSync(0xc0066ba000)
	/src/oxia/server/wal/wal_impl.go:387 +0x36c
github.com/streamnative/oxia/common.DoWithLabels.func1({0x2540318?, 0xc00372f680?})
	/src/oxia/common/pprof.go:46 +0x13
runtime/pprof.Do({0x2540350?, 0xc00a8dde50?}, {{0xc00c2168a0?, 0x1e?, 0x711?}}, 0xc001268f30)
	/usr/local/go/src/runtime/pprof/runtime.go:51 +0x8c
github.com/streamnative/oxia/common.DoWithLabels({0x2540350, 0xc00a8dde50}, 0xc00372e9f0, 0xc0073efaa0)
	/src/oxia/common/pprof.go:42 +0x34d
created by github.com/streamnative/oxia/server/wal.newWal in goroutine 145333831
	/src/oxia/server/wal/wal_impl.go:149 +0xa6f

@mattisonchao mattisonchao marked this pull request as draft April 21, 2025 14:58
@mattisonchao mattisonchao marked this pull request as ready for review April 25, 2025 15:02
@merlimat merlimat merged commit e783182 into main Apr 26, 2025
8 checks passed
@merlimat merlimat deleted the fix.panic.nil branch April 26, 2025 14:14
mattisonchao added a commit that referenced this pull request Aug 12, 2025
### Motivation

#668 introduced a regression that made concurrent writes fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants