fix(leader): fix the concurrent write causes disordered offset#738
Merged
mattisonchao merged 3 commits intomainfrom Aug 12, 2025
Merged
fix(leader): fix the concurrent write causes disordered offset#738mattisonchao merged 3 commits intomainfrom
mattisonchao merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a concurrency bug in the leader controller where concurrent writes could result in disordered offsets, addressing a regression introduced by issue #668.
- Moves the mutex unlock operation after the WAL append operation to ensure proper synchronization
- Refactors the WAL append callback to be defined before the append call for better code organization
- Adds a comprehensive test case to verify concurrent write operations work correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/leader_controller.go | Fixes the concurrent write issue by properly ordering mutex unlock and WAL append operations |
| server/leader_controller_test.go | Adds test coverage for concurrent write scenarios to prevent regression |
RobertIndie
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#668 introduced a regression that made concurrent writes fail.