Conversation
Collaborator
dkalinichenko-js
left a comment
There was a problem hiding this comment.
It would be good to add a test that float32 and float32# primitive types are not defined with -extension-universe upstream_compatible.
dkalinichenko-js
approved these changes
Aug 14, 2024
Member
Author
|
Sure, added for both small_numbers and simd. The output is slightly different than |
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
* Revert "Move float32 back to beta (oxcaml#2843)" This reverts commit 4846e6c. * fix test * upstream_compatible test * upstream_compatible simd test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To merge after javascript/wasm support is released.
To fix bytecode float32 constants in stdlib_stable, we will also need to stop compiling otherlibs with the boot compiler.