Merged
Conversation
dkalinichenko-js
approved these changes
Jul 24, 2024
ncik-roberts
added a commit
that referenced
this pull request
Jul 24, 2024
* Move float32 back to beta * Fix `make runtest` * Fix runtime5 tests (cherry picked from commit 4846e6c)
TheNumbat
added a commit
that referenced
this pull request
Aug 14, 2024
lukemaurer
pushed a commit
to lukemaurer/flambda-backend
that referenced
this pull request
Oct 23, 2024
* Move float32 back to beta * Fix `make runtest` * Fix runtime5 tests
lukemaurer
pushed a commit
that referenced
this pull request
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move float32 back to
stdlib_beta. That's bothFloat32andFloat32_u. That involves:stdlib_stabletostdlib_beta.Stdlib_stable.Float32back toStdlib_beta.Float32We can revert this when float32 is ready to be moved back to stable.