Migrate modes into the parsetree#2741
Merged
freemagma merged 70 commits intooxcaml:mainfrom Aug 1, 2024
Merged
Conversation
… parsetree.migrate-modes
… parsetree.migrate-modes
17d6f1a to
63126cf
Compare
…r-n-ary-functions' into parsetree.migrate-modes
riaqn
reviewed
Jul 16, 2024
riaqn
approved these changes
Jul 16, 2024
Contributor
riaqn
left a comment
There was a problem hiding this comment.
LGTM (please address the new comment about pprintast.ml)
Collaborator
|
Why did this get closed? Is there another PR this work is continued on? |
Contributor
|
The PR was automatically closed as the result of me merging a PR. Charlie and I are figuring out how to re-open it. |
Contributor
|
Apparently I had perms to reopen it after Charlie undeleted the branch, but Charlie did not. Great! It's reopened. |
lukemaurer
pushed a commit
that referenced
this pull request
Oct 23, 2024
* added modes to the parsetree and removed `Jane_syntax.Mode_expr` --------- Co-authored-by: Charlie Gunn <cgunn@janestreet.com> Co-authored-by: Richard Eisenberg <reisenberg@janestreet.com> Co-authored-by: Nick Roberts <nroberts@janestreet.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the mode syntax from attributes to parsetree.
An older version of this PR is at freemagma#1, where most conversations are now resolved.