Skip to content

feat(tsconfig): complete inheritance of compilerOptions fields#657

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-24-feat_tsconfig_complete_inheritance_of_compileroptions_fields
Aug 25, 2025
Merged

feat(tsconfig): complete inheritance of compilerOptions fields#657
graphite-app[bot] merged 1 commit intomainfrom
08-24-feat_tsconfig_complete_inheritance_of_compileroptions_fields

Conversation

@shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Aug 23, 2025

Some compilerOptions fields were added without implementing the corresponding inheritance logic.

Copy link
Contributor Author

shulaoda commented Aug 23, 2025


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda changed the title feat(tsconfig): complete inheritance of compilerOptions fields feat(tsconfig): complete inheritance of compilerOptions fields Aug 23, 2025
@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

❌ Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.00%. Comparing base (e8b1acd) to head (547bce7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tsconfig.rs 92.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   95.03%   95.00%   -0.04%     
==========================================
  Files          12       12              
  Lines        2820     2860      +40     
==========================================
+ Hits         2680     2717      +37     
- Misses        140      143       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shulaoda shulaoda marked this pull request as ready for review August 23, 2025 21:34
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 23, 2025

CodSpeed Performance Report

Merging #657 will not alter performance

Comparing 08-24-feat_tsconfig_complete_inheritance_of_compileroptions_fields (547bce7) with main (4e1c895)1

Summary

✅ 3 untouched benchmarks

Footnotes

  1. No successful run was found on main (e8b1acd) during the generation of this report, so 4e1c895 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@shulaoda shulaoda requested a review from Boshen August 23, 2025 22:37
@Boshen Boshen self-assigned this Aug 24, 2025
@shulaoda shulaoda force-pushed the 08-24-feat_tsconfig_complete_inheritance_of_compileroptions_fields branch from 5e001e4 to b9a250a Compare August 24, 2025 17:53
@shulaoda shulaoda changed the base branch from main to graphite-base/657 August 24, 2025 17:56
@shulaoda shulaoda changed the base branch from graphite-base/657 to main August 24, 2025 17:57
@shulaoda shulaoda changed the base branch from main to 08-24-fix_tsconfig_respect_yarn_pnp_when_resolving_extends_paths August 24, 2025 17:59
@shulaoda shulaoda force-pushed the 08-24-feat_tsconfig_complete_inheritance_of_compileroptions_fields branch from b9a250a to 38a84ae Compare August 24, 2025 18:00
@shulaoda shulaoda force-pushed the 08-24-fix_tsconfig_respect_yarn_pnp_when_resolving_extends_paths branch from a222341 to 0480460 Compare August 24, 2025 18:00
@shulaoda shulaoda force-pushed the 08-24-feat_tsconfig_complete_inheritance_of_compileroptions_fields branch from 38a84ae to 22528e9 Compare August 24, 2025 18:06
@graphite-app graphite-app bot added the merge label Aug 25, 2025
@graphite-app
Copy link

graphite-app bot commented Aug 25, 2025

Merge activity

Some `compilerOptions` fields were added without implementing the corresponding inheritance logic.
@graphite-app graphite-app bot force-pushed the 08-24-fix_tsconfig_respect_yarn_pnp_when_resolving_extends_paths branch from 0480460 to e8b1acd Compare August 25, 2025 01:34
@graphite-app graphite-app bot force-pushed the 08-24-feat_tsconfig_complete_inheritance_of_compileroptions_fields branch from 22528e9 to 547bce7 Compare August 25, 2025 01:35
Base automatically changed from 08-24-fix_tsconfig_respect_yarn_pnp_when_resolving_extends_paths to main August 25, 2025 01:38
@graphite-app graphite-app bot merged commit 547bce7 into main Aug 25, 2025
15 checks passed
@graphite-app graphite-app bot removed the merge label Aug 25, 2025
@graphite-app graphite-app bot deleted the 08-24-feat_tsconfig_complete_inheritance_of_compileroptions_fields branch August 25, 2025 01:39
@oxc-bot oxc-bot mentioned this pull request Aug 25, 2025
Boshen added a commit that referenced this pull request Aug 25, 2025
## 🤖 New release

* `oxc_resolver`: 11.6.2 -> 11.7.0
* `oxc_resolver_napi`: 11.6.2 -> 11.7.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `oxc_resolver`

<blockquote>

##
[11.7.0](v11.6.2...v11.7.0)
- 2025-08-25

### <!-- 0 -->🚀 Features

- *(tsconfig)* support `files` / `include` / `exclude`
([#659](#659)) (by
@shulaoda)
- feat(tsconfig) support `allowJs` in `compilerOptions`
([#658](#658)) (by
@shulaoda) - #658
- *(tsconfig)* complete inheritance of `compilerOptions` fields
([#657](#657)) (by
@shulaoda)

### <!-- 1 -->🐛 Bug Fixes

- *(tsconfig)* respect Yarn PnP when resolving `extends` paths
([#656](#656)) (by
@shulaoda)

### <!-- 6 -->🧪 Testing

- *(tsconfig)* tweak jsx `extends` tests
([#666](#666)) (by
@shulaoda)

### <!-- 9 -->💼 Other

- Add comprehensive tests for tsconfig extends functionality
([#660](#660)) (by
@Copilot) - #660

### Contributors

* @shulaoda
* @renovate[bot]
* @Copilot
</blockquote>



</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

---------

Co-authored-by: Boshen <boshenc@gmail.com>
@oxc-bot oxc-bot mentioned this pull request Aug 25, 2025
@oxc-bot oxc-bot mentioned this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants