Skip to content

fix(tsconfig): respect Yarn PnP when resolving extends paths#656

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-24-fix_tsconfig_respect_yarn_pnp_when_resolving_extends_paths
Aug 25, 2025
Merged

fix(tsconfig): respect Yarn PnP when resolving extends paths#656
graphite-app[bot] merged 1 commit intomainfrom
08-24-fix_tsconfig_respect_yarn_pnp_when_resolving_extends_paths

Conversation

@shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Aug 23, 2025

Copy link
Contributor Author

shulaoda commented Aug 23, 2025


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shulaoda shulaoda changed the title fix(tsconfig): respect Yarn PnP when resolving extends paths fix(tsconfig): respect Yarn PnP when resolving extends paths Aug 23, 2025
@shulaoda shulaoda marked this pull request as ready for review August 23, 2025 20:59
@shulaoda shulaoda requested a review from Boshen August 23, 2025 20:59
@shulaoda shulaoda force-pushed the 08-24-fix_tsconfig_respect_yarn_pnp_when_resolving_extends_paths branch from c54f3d4 to 1e8c34c Compare August 23, 2025 21:01
@codecov
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.03%. Comparing base (4e1c895) to head (e8b1acd).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #656   +/-   ##
=======================================
  Coverage   95.02%   95.03%           
=======================================
  Files          12       12           
  Lines        2816     2820    +4     
=======================================
+ Hits         2676     2680    +4     
  Misses        140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 23, 2025

CodSpeed Performance Report

Merging #656 will not alter performance

Comparing 08-24-fix_tsconfig_respect_yarn_pnp_when_resolving_extends_paths (e8b1acd) with main (4e1c895)1

Summary

✅ 3 untouched benchmarks

Footnotes

  1. No successful run was found on main (18a69d4) during the generation of this report, so 4e1c895 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen self-assigned this Aug 24, 2025
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stack of PRs are lacking tests, I assume we lacked them in the first place so I added some by AI #660

can you restack and also add relevant units so the lines are covered?

@shulaoda shulaoda force-pushed the 08-24-fix_tsconfig_respect_yarn_pnp_when_resolving_extends_paths branch 2 times, most recently from 97c2a89 to c3435f7 Compare August 24, 2025 17:44
@graphite-app graphite-app bot added the merge label Aug 25, 2025
@graphite-app
Copy link

graphite-app bot commented Aug 25, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 08-24-fix_tsconfig_respect_yarn_pnp_when_resolving_extends_paths branch from 0480460 to e8b1acd Compare August 25, 2025 01:34
@graphite-app graphite-app bot merged commit e8b1acd into main Aug 25, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 08-24-fix_tsconfig_respect_yarn_pnp_when_resolving_extends_paths branch August 25, 2025 01:38
@graphite-app graphite-app bot removed the merge label Aug 25, 2025
@oxc-bot oxc-bot mentioned this pull request Aug 24, 2025
Boshen added a commit that referenced this pull request Aug 25, 2025
## 🤖 New release

* `oxc_resolver`: 11.6.2 -> 11.7.0
* `oxc_resolver_napi`: 11.6.2 -> 11.7.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `oxc_resolver`

<blockquote>

##
[11.7.0](v11.6.2...v11.7.0)
- 2025-08-25

### <!-- 0 -->🚀 Features

- *(tsconfig)* support `files` / `include` / `exclude`
([#659](#659)) (by
@shulaoda)
- feat(tsconfig) support `allowJs` in `compilerOptions`
([#658](#658)) (by
@shulaoda) - #658
- *(tsconfig)* complete inheritance of `compilerOptions` fields
([#657](#657)) (by
@shulaoda)

### <!-- 1 -->🐛 Bug Fixes

- *(tsconfig)* respect Yarn PnP when resolving `extends` paths
([#656](#656)) (by
@shulaoda)

### <!-- 6 -->🧪 Testing

- *(tsconfig)* tweak jsx `extends` tests
([#666](#666)) (by
@shulaoda)

### <!-- 9 -->💼 Other

- Add comprehensive tests for tsconfig extends functionality
([#660](#660)) (by
@Copilot) - #660

### Contributors

* @shulaoda
* @renovate[bot]
* @Copilot
</blockquote>



</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

---------

Co-authored-by: Boshen <boshenc@gmail.com>
@oxc-bot oxc-bot mentioned this pull request Aug 25, 2025
@oxc-bot oxc-bot mentioned this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Yarn PnP is not working with native plugins

2 participants