Skip to content

refactor(linter, syntax): introduce type alias FxDashMap#7520

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-28-refactor_linter_syntax_introduce_type_alias_fxdashmap_
Nov 28, 2024
Merged

refactor(linter, syntax): introduce type alias FxDashMap#7520
graphite-app[bot] merged 1 commit intomainfrom
11-28-refactor_linter_syntax_introduce_type_alias_fxdashmap_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 28, 2024

Pure refactor. Introduce a type alias FxDashMap<K, V> for DashMap<K, V, FxBuildHasher>. This makes the code using it clearer.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

overlookmotel commented Nov 28, 2024

@overlookmotel overlookmotel marked this pull request as ready for review November 28, 2024 11:14
@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 28, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #7520 will not alter performance

Comparing 11-28-refactor_linter_syntax_introduce_type_alias_fxdashmap_ (169b8bf) with main (7ebe8c2)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 28, 2024
Copy link
Member

Boshen commented Nov 28, 2024

Merge activity

  • Nov 28, 6:38 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 28, 6:38 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 28, 6:51 AM EST: A user merged this pull request with the Graphite merge queue.

Pure refactor. Introduce a type alias `FxDashMap<K, V>` for `DashMap<K, V, FxBuildHasher>`. This makes the code using it clearer.
@Boshen Boshen force-pushed the 11-28-refactor_linter_syntax_introduce_type_alias_fxdashmap_ branch from 646e513 to 169b8bf Compare November 28, 2024 11:45
@graphite-app graphite-app bot merged commit 169b8bf into main Nov 28, 2024
@graphite-app graphite-app bot deleted the 11-28-refactor_linter_syntax_introduce_type_alias_fxdashmap_ branch November 28, 2024 11:51
@oxc-bot oxc-bot mentioned this pull request Dec 1, 2024
Boshen added a commit that referenced this pull request Dec 1, 2024
## [0.14.0] - 2024-12-01

### Features

- 32f860d linter: Add support for ignorePatterns property within config
file (#7092) (Nicholas Rayburn)
- 053bc08 linter: Implement typescript/no-unused-expressions (#7498)
(camc314)
- 60b28fc linter: Implement typescript/consistent-generic-constructors
(#7497) (camc314)
- bd0693b linter: Allow lint rules with the same name (#7496) (camc314)
- 2ac9f96 linter: Typescript/no-inferrable-types (#7438) (camc314)
- 8d89fdc linter: Add eslint/prefer-spread (#7112) (tbashiyy)

### Bug Fixes

- 123b5b7 linter: False positive in
`typescript/consistent-type-definitions` (#7560) (dalaoshu)
- cc078d6 linter: Add missing error message prefix to
`eslint/no-const-assign` (Boshen)
- 17c0dd8 linter: Fix `jsx_no_script_url` doc failed to build (Boshen)

### Performance

- 6cc7a48 linter: Use `OsString` for module cache hash (#7558) (Boshen)
- 6655345 linter: Use `FxDashMap` for module cache (#7522)
(overlookmotel)

### Documentation

- a6b0100 linter: Fix config example headings (#7562) (Boshen)

### Refactor

- 0f3f67a linter: Add capability of adding semantic data to module
record (#7561) (Boshen)
- 8392177 linter: Clean up the runtime after the module record change
(#7557) (Boshen)
- 823353a linter: Clean up APIs for `ModuleRecord` (#7556) (Boshen)
- f847d0f linter: Call `str::ends_with` with array not slice (#7526)
(overlookmotel)
- 2077ff9 linter: Remove `once_cell` (#7510) (Boshen)
- 169b8bf linter, syntax: Introduce type alias `FxDashMap` (#7520)
(overlookmotel)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants