feat(linter): add eslint/prefer-spread#7112
Merged
Boshen merged 7 commits intooxc-project:mainfrom Nov 26, 2024
Merged
Conversation
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
eslint:prefer-spraedeslint:prefer-spread
tbashiyy
commented
Nov 4, 2024
CodSpeed Performance ReportMerging #7112 will not alter performanceComparing Summary
|
45944ea to
e5ac1a5
Compare
…ombine with eslint:prefer-spread original rule
e5ac1a5 to
390a89d
Compare
Member
|
@camc314 seems like the last rule PR. 🙇 |
camc314
approved these changes
Nov 25, 2024
Contributor
|
@Boshen do you think these we should fix the naming colisions and split these two rules. they do unrelated things (i won't let this block this PR though) |
Contributor
|
lol not sure why i didn't approve originally |
Boshen
reviewed
Nov 25, 2024
eslint:prefer-spread
Boshen
added a commit
that referenced
this pull request
Dec 1, 2024
## [0.14.0] - 2024-12-01 ### Features - 32f860d linter: Add support for ignorePatterns property within config file (#7092) (Nicholas Rayburn) - 053bc08 linter: Implement typescript/no-unused-expressions (#7498) (camc314) - 60b28fc linter: Implement typescript/consistent-generic-constructors (#7497) (camc314) - bd0693b linter: Allow lint rules with the same name (#7496) (camc314) - 2ac9f96 linter: Typescript/no-inferrable-types (#7438) (camc314) - 8d89fdc linter: Add eslint/prefer-spread (#7112) (tbashiyy) ### Bug Fixes - 123b5b7 linter: False positive in `typescript/consistent-type-definitions` (#7560) (dalaoshu) - cc078d6 linter: Add missing error message prefix to `eslint/no-const-assign` (Boshen) - 17c0dd8 linter: Fix `jsx_no_script_url` doc failed to build (Boshen) ### Performance - 6cc7a48 linter: Use `OsString` for module cache hash (#7558) (Boshen) - 6655345 linter: Use `FxDashMap` for module cache (#7522) (overlookmotel) ### Documentation - a6b0100 linter: Fix config example headings (#7562) (Boshen) ### Refactor - 0f3f67a linter: Add capability of adding semantic data to module record (#7561) (Boshen) - 8392177 linter: Clean up the runtime after the module record change (#7557) (Boshen) - 823353a linter: Clean up APIs for `ModuleRecord` (#7556) (Boshen) - f847d0f linter: Call `str::ends_with` with array not slice (#7526) (overlookmotel) - 2077ff9 linter: Remove `once_cell` (#7510) (Boshen) - 169b8bf linter, syntax: Introduce type alias `FxDashMap` (#7520) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR,
unicorn:prefer-spreadtoeslint:prefer-spread.eslint:prefer-spreadandunicorn:prefer-spread(This is already talked in discord)