Skip to content

test(transformer): script to amend Babel fixtures#7122

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-04-test_transformer_script_to_amend_babel_fixtures
Nov 25, 2024
Merged

test(transformer): script to amend Babel fixtures#7122
graphite-app[bot] merged 1 commit intomainfrom
11-04-test_transformer_script_to_amend_babel_fixtures

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Nov 4, 2024 •
edited
Loading

Add a NodeJS script which amends Babel's fixtures in place to remove transform plugins which we don't support from options.json files. Where options are changed from the original, the script runs Babel transform with the new options to regenerate the fixture output.js files.

Currently limited to transforming the fixtures for babel-plugin-transform-class-properties transform, but we can also enable it for other plugins if we wish in future, to get additional test coverage.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Nov 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Nov 4, 2024
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Nov 4, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Nov 4, 2024
Merged
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 8dfe8ba to f559460 Compare November 4, 2024 18:00
@overlookmotel overlookmotel changed the base branch from main to 11-04-refactor_ast_use_scope_id_etc_methods November 4, 2024 18:00
This was referenced Nov 4, 2024
Merged
Merged
Merged
Merged
Merged
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 4, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #7122 will not alter performance

Comparing 11-04-test_transformer_script_to_amend_babel_fixtures (7f0dd2c) with 11-22-feat_traverse_add_methods_to_boundidentifier_maybeboundidentifier_to_create_simpleassignmenttarget_s (1a6116b)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen changed the base branch from 11-04-refactor_ast_use_scope_id_etc_methods to graphite-base/7122 November 5, 2024 02:27
@Boshen Boshen force-pushed the graphite-base/7122 branch from 80ea830 to fac5042 Compare November 5, 2024 02:54
@Boshen Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from f559460 to 5dde378 Compare November 5, 2024 02:54
@Boshen Boshen changed the base branch from graphite-base/7122 to main November 5, 2024 02:55
@Boshen Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 5dde378 to 3dfe91b Compare November 5, 2024 02:55
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch 3 times, most recently from 5dbd95a to 8f6d9bd Compare November 6, 2024 22:26
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch 3 times, most recently from fdf277f to 7b2ad89 Compare November 15, 2024 00:38
@overlookmotel overlookmotel changed the base branch from main to 11-15-fix_codegen_fix_arithmetic_overflow_printing_unspanned_newexpression_ November 15, 2024 00:38
@overlookmotel overlookmotel mentioned this pull request Nov 15, 2024
Merged
@Boshen Boshen changed the base branch from 11-15-fix_codegen_fix_arithmetic_overflow_printing_unspanned_newexpression_ to graphite-base/7122 November 15, 2024 02:56
@Boshen Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 7b2ad89 to e306f43 Compare November 15, 2024 03:01
@Boshen Boshen force-pushed the graphite-base/7122 branch from 6de410a to 33ec4e6 Compare November 15, 2024 03:01
@Boshen Boshen changed the base branch from graphite-base/7122 to main November 15, 2024 03:02
@overlookmotel overlookmotel changed the base branch from 11-18-feat_syntax_add_symbolid_new_and_symbolid_dummy_ to 11-18-perf_syntax_reorder_operator_enum_variants November 18, 2024 22:15
This was referenced Nov 18, 2024
Merged
Merged
Merged
@overlookmotel overlookmotel force-pushed the 11-18-perf_syntax_reorder_operator_enum_variants branch from 03d2dad to 2ce3a79 Compare November 18, 2024 22:32
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 9af826a to b1b4822 Compare November 18, 2024 22:32
@overlookmotel overlookmotel force-pushed the 11-18-perf_syntax_reorder_operator_enum_variants branch from 2ce3a79 to 82b8c74 Compare November 18, 2024 22:37
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from b1b4822 to 75d160d Compare November 18, 2024 22:37
@Boshen Boshen changed the base branch from 11-18-perf_syntax_reorder_operator_enum_variants to graphite-base/7122 November 19, 2024 01:12
@Boshen Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 75d160d to 3ac608a Compare November 19, 2024 01:34
@Boshen Boshen force-pushed the graphite-base/7122 branch from 82b8c74 to c335f92 Compare November 19, 2024 01:35
@Boshen Boshen changed the base branch from graphite-base/7122 to main November 19, 2024 01:35
@Boshen Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 3ac608a to 92335db Compare November 19, 2024 01:35
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch 2 times, most recently from 7b6eb47 to db27b52 Compare November 19, 2024 17:54
@overlookmotel overlookmotel changed the base branch from main to 11-19-fix_traverse_implement_gathernodeparts_for_member_expression_types November 19, 2024 17:55
@overlookmotel overlookmotel mentioned this pull request Nov 19, 2024
Merged
@Dunqing Dunqing changed the base branch from 11-19-fix_traverse_implement_gathernodeparts_for_member_expression_types to graphite-base/7122 November 20, 2024 03:58
@Dunqing Dunqing force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from db27b52 to f402b33 Compare November 20, 2024 04:03
@Dunqing Dunqing changed the base branch from graphite-base/7122 to main November 20, 2024 04:04
@Dunqing Dunqing force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from f402b33 to afb014a Compare November 20, 2024 04:04
@overlookmotel overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch 2 times, most recently from d3109f0 to dc1838a Compare November 20, 2024 16:39
This was referenced Nov 21, 2024
Merged
Merged
Merged
Boshen
Boshen reviewed Nov 24, 2024
View reviewed changes
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Nov 25, 2024 •
edited
Loading

Merge activity

@overlookmotel
test(transformer): script to amend Babel fixtures (#7122)
3b2a347 
Add a NodeJS script which amends Babel's fixtures in place to remove transform plugins which we don't support from `options.json` files. Where options are changed from the original, the script runs Babel transform with the new options to regenerate the fixture `output.js` files.

Currently limited to transforming the fixtures for `babel-plugin-transform-class-properties` transform, but we can also enable it for other plugins if we wish in future, to get additional test coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees

No one assigned

Labels

0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel @Boshen