feat(transformer): class properties transform by overlookmotel · Pull Request #7011 · oxc-project/oxc

overlookmotel · 2024-10-29T23:37:49Z

Add class properties transform.

Implementation is incomplete. Notable missing parts:

Scopes are not updated where property initializers move from class body into class constructor / _super function.
Does not handle binding shadowing problems when property initializers move from class body into class constructor.
this and references to class name in static property initializers need to be transformed to point to a temp var.
Not all usages of private properties are supported (see below).
Code which is moved to outside of class body is not transformed by other transforms for class declarations (works OK for class expressions). This includes static property initializers, static blocks, and computed property/method keys.
Only basic checks for whether computed property/method keys may have side effects.
Numerous other small issues noted in TODO comments through the code.

Private properties

Currently does not handle the following usages of private properties:

class Class {
  #prop;
  static #static;
  
  method() {
    object?.#prop;
    object?.#prop();
    [object.#prop] = [1];
    ({x: object.#prop} = {x: 1});
    object.#prop`xyz`;
    
    object?.#static;
    object?.#static();
    [object.#static] = [1];
    ({x: object.#static} = {x: 1});
    object.#static`xyz`;
  }
}

graphite-app · 2024-10-29T23:37:54Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

overlookmotel · 2024-10-29T23:38:12Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2024-10-30T00:26:39Z

CodSpeed Performance Report

Merging #7011 will degrade performances by 19.21%

_{Comparing 10-29-feat_transformer_class_properties_transform (9778298) with main (0b9da38)}

Summary

❌ 3 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`main`	`10-29-feat_transformer_class_properties_transform`	Change
❌	`transformer[antd.js]`	49.6 ms	53.9 ms	-7.98%
❌	`transformer[checker.ts]`	20.8 ms	23.1 ms	-9.97%
❌	`transformer[pdf.mjs]`	7.8 ms	9.6 ms	-19.21%

Boshen

Too much fixtures committed to this repo, let me think about #4048

overlookmotel · 2024-10-31T09:09:29Z

Yes, I hope there's a better solution. I just wanted some working tests while I'm building the transform.

Skeleton of class properties transform. #7011 contains WIP implementation.

overlookmotel · 2024-11-21T23:50:51Z

@Boshen How do I run monitor-oxc on this branch?

(probably still some failures, but would help to see what they are)

overlookmotel · 2024-11-24T14:23:04Z

@Boshen @Dunqing As noted above, this transform is incomplete. But I think it's in a fit state to merge at this point so we can iterate on it.

Note: Transform is not enabled by default, so I think monitor-oxc won't fail if we merge this.

Boshen · 2024-11-25T10:23:49Z

Merge activity

Nov 25, 5:23 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 25, 5:23 AM EST: A user added this pull request to the Graphite merge queue.
Nov 25, 5:30 AM EST: A user merged this pull request with the Graphite merge queue.

Add class properties transform. Implementation is incomplete. Notable missing parts: * Scopes are not updated where property initializers move from class body into class constructor / `_super` function. * Does not handle binding shadowing problems when property initializers move from class body into class constructor. * `this` and references to class name in static property initializers need to be transformed to point to a temp var. * Not all usages of private properties are supported (see below). * Code which is moved to outside of class body is not transformed by other transforms for class declarations (works OK for class expressions). This includes static property initializers, static blocks, and computed property/method keys. * Only basic checks for whether computed property/method keys may have side effects. * Numerous other small issues noted in TODO comments through the code. ### Private properties Currently does not handle the following usages of private properties: ```js class Class { #prop; static #static; method() { object?.#prop; object?.#prop(); [object.#prop] = [1]; ({x: object.#prop} = {x: 1}); object.#prop`xyz`; object?.#static; object?.#static(); [object.#static] = [1]; ({x: object.#static} = {x: 1}); object.#static`xyz`; } } ```

github-actions bot added A-ast Area - AST A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Oct 29, 2024

overlookmotel force-pushed the 10-29-feat_transformer_class_properties_transform branch from 0eb3ad7 to 906e8fd Compare October 29, 2024 23:39

overlookmotel force-pushed the 10-29-feat_transformer_class_properties_transform branch 3 times, most recently from 7b2ad83 to 1f4eef9 Compare October 30, 2024 18:48

overlookmotel changed the base branch from main to 10-30-test_transformer_support_exec_tests_in_oxc_folder October 30, 2024 18:48

overlookmotel mentioned this pull request Oct 30, 2024

test(transformer): support exec tests in Oxc folder #7030

Merged

overlookmotel marked this pull request as ready for review October 30, 2024 18:49

overlookmotel force-pushed the 10-29-feat_transformer_class_properties_transform branch 2 times, most recently from 366cc8f to 65400df Compare October 30, 2024 19:59

Boshen changed the base branch from 10-30-test_transformer_support_exec_tests_in_oxc_folder to graphite-base/7011 October 31, 2024 01:18

Boshen reviewed Oct 31, 2024

View reviewed changes

Boshen force-pushed the graphite-base/7011 branch from 96a98ba to 2a57a66 Compare October 31, 2024 01:26

Boshen force-pushed the 10-29-feat_transformer_class_properties_transform branch from 5663771 to 0c69972 Compare October 31, 2024 01:26

Boshen changed the base branch from graphite-base/7011 to main October 31, 2024 01:27

Boshen force-pushed the 10-29-feat_transformer_class_properties_transform branch from 0c69972 to 3970e03 Compare October 31, 2024 01:27

overlookmotel mentioned this pull request Oct 31, 2024

feat(transformer): class properties transform skeleton #7038

Merged

Boshen marked this pull request as draft October 31, 2024 09:55

Boshen pushed a commit that referenced this pull request Oct 31, 2024

feat(transformer): class properties transform skeleton (#7038)

1d906c6

Skeleton of class properties transform. #7011 contains WIP implementation.

overlookmotel force-pushed the 10-29-feat_transformer_class_properties_transform branch 3 times, most recently from c71dda8 to 78b7bed Compare October 31, 2024 20:40

overlookmotel changed the base branch from main to 10-31-refactor_transformer_common_vardeclarations_insert_either_var_or_let_statements October 31, 2024 20:40

overlookmotel mentioned this pull request Oct 31, 2024

refactor(transformer/common): VarDeclarations insert either var or let statements #7043

Merged

overlookmotel force-pushed the 10-29-feat_transformer_class_properties_transform branch 2 times, most recently from bc9b16c to 22e497f Compare November 15, 2024 13:37

overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 8dacaf8 to 47de3f8 Compare November 15, 2024 19:01

overlookmotel force-pushed the 10-29-feat_transformer_class_properties_transform branch from 0c9a6dd to 5c8876d Compare November 15, 2024 19:01

overlookmotel mentioned this pull request Nov 15, 2024

feat(traverse): add methods for creating Expression::Identifiers #7301

Merged

overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 47de3f8 to ac59297 Compare November 15, 2024 21:04

overlookmotel force-pushed the 10-29-feat_transformer_class_properties_transform branch from 5c8876d to 53007ed Compare November 15, 2024 21:04

This was referenced Nov 15, 2024

refactor(transformer): helper loader methods take Span #7304

Merged

feat(data_structures): add methods to SparseStack #7305

Merged

Boshen force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch 2 times, most recently from 11d4da4 to 9d7953d Compare November 16, 2024 05:54

Boshen force-pushed the 10-29-feat_transformer_class_properties_transform branch from 66be587 to 6e392cf Compare November 16, 2024 05:54

overlookmotel force-pushed the 11-04-test_transformer_script_to_amend_babel_fixtures branch from 9d7953d to afc4792 Compare November 17, 2024 12:21

This was referenced Nov 22, 2024

docs(traverse): fix docs for BoundIdentifier + MaybeBoundIdentifier #7417

Merged

feat(traverse): add methods to BoundIdentifier + MaybeBoundIdentifier to create SimpleAssignmentTargets #7418

Merged

Boshen mentioned this pull request Nov 25, 2024

transformer: typescript --useDefineForClassFields #6735

Closed

oxc-bot mentioned this pull request Nov 26, 2024

release(crates): v0.38.0 #7490

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(transformer): class properties transform#7011

feat(transformer): class properties transform#7011
graphite-app[bot] merged 1 commit intomainfrom
10-29-feat_transformer_class_properties_transform

overlookmotel commented Oct 29, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 29, 2024

Uh oh!

overlookmotel commented Oct 29, 2024 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 30, 2024 •

edited

Loading

Uh oh!

Boshen left a comment

Uh oh!

overlookmotel commented Oct 31, 2024

Uh oh!

overlookmotel commented Nov 21, 2024 •

edited

Loading

Uh oh!

overlookmotel commented Nov 24, 2024 •

edited

Loading

Uh oh!

Boshen commented Nov 25, 2024 •

edited by graphite-app bot

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

overlookmotel commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Private properties

Uh oh!

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

overlookmotel commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #7011 will degrade performances by 19.21%

Summary

Benchmarks breakdown

Uh oh!

Boshen left a comment

Choose a reason for hiding this comment

Uh oh!

overlookmotel commented Oct 31, 2024

Uh oh!

overlookmotel commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Nov 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Boshen commented Nov 25, 2024 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

overlookmotel commented Oct 29, 2024 •

edited

Loading

overlookmotel commented Oct 29, 2024 •

edited

Loading

codspeed-hq bot commented Oct 30, 2024 •

edited

Loading

overlookmotel commented Nov 21, 2024 •

edited

Loading

overlookmotel commented Nov 24, 2024 •

edited

Loading

Boshen commented Nov 25, 2024 •

edited by graphite-app bot

Loading