refactor(all): shorten redundant std::vec::Vec#23748
Merged
graphite-app[bot] merged 1 commit intoJun 24, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 23, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors several Rust modules across the workspace to shorten explicit std::vec::Vec type paths to the prelude Vec, now that arena vectors are consistently named ArenaVec (per prior refactor) and Vec is unambiguous.
Changes:
- Replaced
std::vec::Vec<T>withVec<T>in function signatures and local variable declarations. - Simplified a few
collect::<std::vec::Vec<_>>()/std::vec::Vec::lenuses tocollect::<Vec<_>>()/Vec::len. - Kept arena-allocated vectors using
ArenaVec, preserving the heap-vs-arena distinction.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_transformer/src/common/module_imports.rs | Uses Vec<Import<'a>> for heap-allocated name lists passed into import/require generation. |
| crates/oxc_regular_expression/src/parser/pattern_parser/pattern_parser_impl.rs | Simplifies a diagnostic helper local names collection to Vec<&str>. |
| crates/oxc_parser/src/module_record.rs | Shortens public-returned error list types to Vec<OxcDiagnostic> while keeping arena storage as ArenaVec. |
| crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs | Simplifies an iterator collect to Vec before join. |
| crates/oxc_minifier/src/keep_var.rs | Stores hoisted vars in Vec<...> without fully qualifying the path. |
| crates/oxc_linter/src/rules/react/jsx_curly_brace_presence.rs | Simplifies several collect::<...>() and a helper return type to Vec. |
| crates/oxc_formatter/src/formatter/jsdoc/wrap.rs | Shortens std::vec::Vec::len to Vec::len when computing column counts. |
| crates/oxc_ecmascript/src/constant_evaluation/call_expr.rs | Uses Vec::new() for temporary number collection in math folding. |
| crates/oxc_ast/src/ast_impl/js.rs | Simplifies helper signatures/returns to Vec for collected identifiers and symbol ids. |
4b2595a to
2ea7dcc
Compare
44b3134 to
e3b8849
Compare
Dunqing
approved these changes
Jun 24, 2026
Contributor
Merge activity
|
Pure refactor. #23748 made all usages of arena-allocated `Vec` be named `ArenaVec`. This makes plain `Vec` unambiguously refer to heap-allocated `Vec` from standard library. Shorten `std::vec::Vec` to just `Vec` in various places.
2ea7dcc to
d1f18cd
Compare
e3b8849 to
f65d8e5
Compare
Base automatically changed from
om/06-23-refactor_all_import_arena_box_and_vec_as_arenabox___arenavec_
to
main
June 24, 2026 01:27
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
Pure refactor. #23748 made all usages of arena-allocated `Vec` be named `ArenaVec`. This makes plain `Vec` unambiguously refer to heap-allocated `Vec` from standard library. Shorten `std::vec::Vec` to just `Vec` in various places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor.
#23748 made all usages of arena-allocated
Vecbe namedArenaVec. This makes plainVecunambiguously refer to heap-allocatedVecfrom standard library.Shorten
std::vec::Vecto justVecin various places.