refactor(allocator): export `ArenaBox` and `ArenaVec` aliases by overlookmotel · Pull Request #23746 · oxc-project/oxc

overlookmotel · 2026-06-23T20:00:54Z

Pure refactor.

It's a common pattern in repo to import Vec and Box etc from oxc_allocator and alias them to ArenaBox / ArenaVec.

use oxc_allocator::{Box as ArenaBox, Vec as ArenaVec};

Make this pattern less verbose by re-exporting Box and Vec as these aliases from oxc_allocator.

Ditto other arena types: ArenaHashMap, ArenaHashSet, ArenaStringBuilder.

Use those aliases in all other crates to shorten code.

use oxc_allocator::{ArenaBox, ArenaVec};

overlookmotel · 2026-06-23T20:01:10Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR is a repository-wide refactor that makes arena allocator imports less verbose by re-exporting common arena-backed types from oxc_allocator under conventional Arena* alias names (e.g. ArenaVec, ArenaBox, ArenaStringBuilder), then updating call sites to use those aliases directly.

Changes:

Re-exported ArenaBox, ArenaVec, ArenaHashMap, ArenaHashSet, and ArenaStringBuilder from oxc_allocator.
Updated Rust modules across the workspace to import Arena* aliases directly (instead of Type as ArenaType).

Reviewed changes

Copilot reviewed 72 out of 72 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
napi/parser/src/raw_transfer.rs	Switch allocator import to `ArenaVec` via `oxc::allocator` re-export.
crates/oxc_traverse/src/context/uid.rs	Replace `StringBuilder as ArenaStringBuilder` with `ArenaStringBuilder`.
crates/oxc_traverse/src/context/scoping.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_traverse/src/context/mod.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_transformer/src/utils/ast_builder.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_transformer/src/typescript/namespace.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_transformer/src/typescript/mod.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_transformer/src/typescript/enum.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_transformer/src/typescript/class.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_transformer/src/typescript/annotations.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_transformer/src/plugins/tagged_template_transform.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_transformer/src/plugins/styled_components.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_transformer/src/lib.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_transformer/src/jsx/refresh.rs	Replace `StringBuilder as ArenaStringBuilder`/`Vec as ArenaVec` with `ArenaStringBuilder`/`ArenaVec`.
crates/oxc_transformer/src/jsx/jsx_impl.rs	Replace `Box as ArenaBox`/`StringBuilder as ArenaStringBuilder`/`Vec as ArenaVec` with `ArenaBox`/`ArenaStringBuilder`/`ArenaVec`.
crates/oxc_transformer/src/es2026/explicit_resource_management.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_transformer/src/es2022/class_properties/super_converter.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_transformer/src/es2022/class_properties/private_field.rs	Replace `Box as ArenaBox` with `ArenaBox`.
crates/oxc_transformer/src/es2020/nullish_coalescing_operator.rs	Replace `Box as ArenaBox` with `ArenaBox`.
crates/oxc_transformer/src/es2018/object_rest_spread.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_transformer/src/es2018/async_generator_functions/for_await.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_transformer/src/es2017/async_to_generator.rs	Replace `Box as ArenaBox`/`StringBuilder as ArenaStringBuilder` with `ArenaBox`/`ArenaStringBuilder`.
crates/oxc_transformer/src/es2016/exponentiation_operator.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_transformer/src/decorator/legacy/mod.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_transformer/src/decorator/legacy/metadata.rs	Replace `Box as ArenaBox` with `ArenaBox`.
crates/oxc_transformer/src/common/var_declarations.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_transformer/src/common/statement_injector.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_transformer/src/common/mod.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_transformer/src/common/helper_loader.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_transformer/src/common/arrow_function_converter.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_transformer_plugins/src/module_runner_transform.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_str/src/str.rs	Replace `StringBuilder as ArenaStringBuilder` with `ArenaStringBuilder`.
crates/oxc_str/src/lib.rs	Update internal re-export to `ArenaStringBuilder`.
crates/oxc_str/src/ident.rs	Replace `StringBuilder as ArenaStringBuilder` with `ArenaStringBuilder`.
crates/oxc_span/src/lib.rs	Update internal re-export to `ArenaStringBuilder`.
crates/oxc_semantic/src/scoping.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_react_compiler/src/convert_ast_reverse.rs	Replace `Box as ArenaBox` with `ArenaBox`.
crates/oxc_parser/src/lib.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_parser/src/lexer/trivia_builder.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_parser/src/lexer/mod.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_minifier/src/traverse_context/uid.rs	Replace `StringBuilder as ArenaStringBuilder` with `ArenaStringBuilder`.
crates/oxc_minifier/src/traverse_context/scoping.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_minifier/src/traverse_context/mod.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_minifier/src/keep_var.rs	Replace `Box as ArenaBox` with `ArenaBox`.
crates/oxc_linter/src/service/runtime.rs	Replace `Box as ArenaBox` with `ArenaBox`.
crates/oxc_linter/src/rules/react/jsx_no_useless_fragment.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_linter/src/rules/eslint/prefer_promise_reject_errors.rs	Replace `Box as ArenaBox` with `ArenaBox`.
crates/oxc_linter/src/rules/eslint/no_useless_return.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_linter/src/rules/eslint/grouped_accessor_pairs.rs	Replace `Box as ArenaBox` with `ArenaBox`.
crates/oxc_linter/src/lib.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_linter/src/context/host.rs	Replace `Box as ArenaBox` with `ArenaBox`.
crates/oxc_isolated_declarations/src/signatures.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_isolated_declarations/src/module.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_isolated_declarations/src/literal.rs	Replace `Box as ArenaBox` with `ArenaBox`.
crates/oxc_isolated_declarations/src/lib.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_isolated_declarations/src/inferrer.rs	Replace `Box as ArenaBox` with `ArenaBox`.
crates/oxc_isolated_declarations/src/function.rs	Replace `Box as ArenaBox` with `ArenaBox`.
crates/oxc_isolated_declarations/src/declaration.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_isolated_declarations/src/class.rs	Replace `Box as ArenaBox`/`Vec as ArenaVec` with `ArenaBox`/`ArenaVec`.
crates/oxc_formatter/src/utils/jsx.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_formatter/src/print/template/mod.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_formatter/src/print/jsx/child_list.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_formatter/src/print/call_like_expression/arguments.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_formatter/src/ir_transform/sort_imports/source_line.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_formatter/src/ir_transform/sort_imports/mod.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_formatter_json/src/parse.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_formatter_core/src/formatter.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_formatter_core/src/format_element/mod.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_formatter_core/src/format_element/document.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_formatter_core/src/builders.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_formatter_core/src/buffer.rs	Replace `Vec as ArenaVec` with `ArenaVec`.
crates/oxc_allocator/src/lib.rs	Add `Arena*` re-exports for common arena-backed types.

codspeed-hq · 2026-06-23T20:09:55Z

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 9 skipped benchmarks¹

_{Comparing om/06-23-refactor_allocator_export_arenabox_and_arenavec_aliases (3f1e6c5) with main (3f574f5)}

9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

graphite-app · 2026-06-24T01:20:51Z

Merge activity

Jun 24, 1:20 AM UTC: Dunqing added this pull request to the Graphite merge queue.
Jun 24, 1:26 AM UTC: Merged by the Graphite merge queue.

Pure refactor. It's a common pattern in repo to import `Vec` and `Box` etc from `oxc_allocator` and alias them to `ArenaBox` / `ArenaVec`. ```rust use oxc_allocator::{Box as ArenaBox, Vec as ArenaVec}; ``` Make this pattern less verbose by re-exporting `Box` and `Vec` as these aliases from `oxc_allocator`. Ditto other arena types: `ArenaHashMap`, `ArenaHashSet`, `ArenaStringBuilder`. Use those aliases in all other crates to shorten code. ```rust use oxc_allocator::{ArenaBox, ArenaVec}; ```

This was referenced Jun 23, 2026

refactor(all): import arena Box and Vec as ArenaBox / ArenaVec #23747

Merged

refactor(all): shorten redundant std::vec::Vec #23748

Merged

refactor(all): use ArenaBox and ArenaVec in generated code #23749

Merged

github-actions Bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler A-isolated-declarations Isolated Declarations A-formatter Area - Formatter A-allocator Area - Allocator labels Jun 23, 2026

overlookmotel marked this pull request as ready for review June 23, 2026 20:03

overlookmotel requested review from Dunqing and leaysgur as code owners June 23, 2026 20:03

Copilot AI review requested due to automatic review settings June 23, 2026 20:03

overlookmotel requested a review from camc314 as a code owner June 23, 2026 20:03

Copilot started reviewing on behalf of overlookmotel June 23, 2026 20:04 View session

Copilot AI reviewed Jun 23, 2026

View reviewed changes

Dunqing approved these changes Jun 24, 2026

View reviewed changes

graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Jun 24, 2026

graphite-app Bot force-pushed the om/06-23-refactor_allocator_export_arenabox_and_arenavec_aliases branch from 3f1e6c5 to 8c6481b Compare June 24, 2026 01:21

graphite-app Bot merged commit 8c6481b into main Jun 24, 2026
31 checks passed

graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jun 24, 2026

graphite-app Bot deleted the om/06-23-refactor_allocator_export_arenabox_and_arenavec_aliases branch June 24, 2026 01:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(allocator): export `ArenaBox` and `ArenaVec` aliases#23746

refactor(allocator): export `ArenaBox` and `ArenaVec` aliases#23746
graphite-app[bot] merged 1 commit into
mainfrom
om/06-23-refactor_allocator_export_arenabox_and_arenavec_aliases

overlookmotel commented Jun 23, 2026 •

edited

Loading

Uh oh!

overlookmotel commented Jun 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed-hq Bot commented Jun 23, 2026

Uh oh!

graphite-app Bot commented Jun 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

overlookmotel commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Jun 23, 2026

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

codspeed-hq Bot commented Jun 23, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

graphite-app Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

overlookmotel commented Jun 23, 2026 •

edited

Loading

graphite-app Bot commented Jun 24, 2026 •

edited

Loading