ci(miri): run Miri with strict provenance enabled#23258
Merged
graphite-app[bot] merged 1 commit intoJun 11, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Enables Miri’s strict provenance checks in CI so that the Miri job(s) detect provenance-related UB under the stricter interpretation, aligning CI with the intended safety guarantees.
Changes:
- Add
-Zmiri-strict-provenanceto Miri runs in the Linux workflow. - Add
-Zmiri-strict-provenanceto the Windows Miri workflow foroxc_allocator. - Document the purpose of the new Miri flag in both workflows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/miri.yml | Sets strict provenance via MIRIFLAGS for the Linux Miri test runs. |
| .github/workflows/miri-windows.yml | Sets strict provenance via MIRIFLAGS for the Windows Miri test run. |
0e3af3e to
437a564
Compare
Contributor
Merge activity
|
I had always understood that Miri ran its checks under strict provenance rules by default, but apparently not. Enable strict provenance in Miri in CI.
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 11, 2026
#23256) Improve the unit tests for `Arena::try_alloc_layout_fast` (which purely does maths, no actual allocations). 1. Add more assertions that ensure test cases are correct. 2. Remove integer to pointer casts which Miri rejects under strict provenance rules. The latter enables running Miri with strict provenance enabled (#23258).
2741679 to
65b6d7a
Compare
437a564 to
b77ca6f
Compare
Base automatically changed from
om/06-10-docs_allocator_fix_memory_leaks_in_arena_examples
to
main
June 11, 2026 00:22
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
#23256) Improve the unit tests for `Arena::try_alloc_layout_fast` (which purely does maths, no actual allocations). 1. Add more assertions that ensure test cases are correct. 2. Remove integer to pointer casts which Miri rejects under strict provenance rules. The latter enables running Miri with strict provenance enabled (#23258).
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
I had always understood that Miri ran its checks under strict provenance rules by default, but apparently not. Enable strict provenance in Miri in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had always understood that Miri ran its checks under strict provenance rules by default, but apparently not. Enable strict provenance in Miri in CI.