Skip to content

refactor(formatter/sort_imports): Eliminate trailing Line(Hard) synthesis#22202

Merged
graphite-app[bot] merged 1 commit into
mainfrom
05-07-refactor_formatter_sort_imports_eliminate_trailing_line_hard_synthesis
May 7, 2026
Merged

refactor(formatter/sort_imports): Eliminate trailing Line(Hard) synthesis#22202
graphite-app[bot] merged 1 commit into
mainfrom
05-07-refactor_formatter_sort_imports_eliminate_trailing_line_hard_synthesis

Conversation

@leaysgur

@leaysgur leaysgur commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Simplify, to use the same shape for in/out.

@leaysgur leaysgur requested a review from Dunqing as a code owner May 7, 2026 04:23
@github-actions github-actions Bot added the A-formatter Area - Formatter label May 7, 2026
@leaysgur Graphite App

leaysgur commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq

codspeed-hq Bot commented May 7, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 44 untouched benchmarks
⏩ 7 skipped benchmarks1

Comparing 05-07-refactor_formatter_sort_imports_eliminate_trailing_line_hard_synthesis (beada27) with 05-07-refactor_formatter_sort_imports_remove_sourceline_others_variant (5f0bb29)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@leaysgur leaysgur changed the title refactor(formatter/sort_imports): Eliminate trailing Line(Hard) synthesis refactor(formatter/sort_imports): Eliminate trailing Line(Hard) synthesis May 7, 2026
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label May 7, 2026
@graphite-app

graphite-app Bot commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@leaysgur
refactor(formatter/sort_imports): Eliminate trailing Line(Hard) syn…
1c10a82 
…thesis (#22202)

Simplify, to use the same shape for in/out.
@graphite-app graphite-app Bot force-pushed the 05-07-refactor_formatter_sort_imports_remove_sourceline_others_variant branch from 5f0bb29 to 01f7836 Compare May 7, 2026 04:34
@graphite-app graphite-app Bot force-pushed the 05-07-refactor_formatter_sort_imports_eliminate_trailing_line_hard_synthesis branch from beada27 to 1c10a82 Compare May 7, 2026 04:35
Base automatically changed from 05-07-refactor_formatter_sort_imports_remove_sourceline_others_variant to main May 7, 2026 04:38
@graphite-app graphite-app Bot merged commit 1c10a82 into main May 7, 2026
30 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 7, 2026
@graphite-app graphite-app Bot deleted the 05-07-refactor_formatter_sort_imports_eliminate_trailing_line_hard_synthesis branch May 7, 2026 04:39
This was referenced May 7, 2026
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

No one assigned

Labels

A-formatter Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@leaysgur