Skip to content

test(allocator): remove tests for size of ChunkFooter#21734

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-24-test_allocator_remove_tests_for_size_of_chunkfooter_
Apr 24, 2026
Merged

test(allocator): remove tests for size of ChunkFooter#21734
graphite-app[bot] merged 1 commit intomainfrom
om/04-24-test_allocator_remove_tests_for_size_of_chunkfooter_

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 24, 2026 •
edited
Loading

Remove 2 tests for the size of ChunkFooter. It's not relevant, and doesn't require tests. These tests will fail if add more fields to ChunkFooter, which is a pain for no gain.

This was referenced Apr 24, 2026
Merged
Merged
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 24, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Apr 24, 2026
Merged
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 24, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing om/04-24-test_allocator_remove_tests_for_size_of_chunkfooter_ (dfc2451) with om/04-24-doc_allocator_improve_doc_comments_for_chunkfooter_ (91c8cce)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on om/04-24-doc_allocator_improve_doc_comments_for_chunkfooter_ (93b7dbd) during the generation of this report, so 9e14ee2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@overlookmotel overlookmotel self-assigned this Apr 24, 2026
@overlookmotel overlookmotel added C-test Category - Testing. Code is missing test cases, or a PR is adding them A-allocator Area - Allocator labels Apr 24, 2026
@overlookmotel overlookmotel marked this pull request as ready for review April 24, 2026 19:52
Copilot AI review requested due to automatic review settings April 24, 2026 19:52
Copilot AI reviewed Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes allocator-internal unit tests that asserted the exact ChunkFooter word-size on 32-bit/64-bit targets, since those tests are brittle and not validating behavior that needs to remain fixed.

Changes:

  • Delete two ChunkFooter size assertion tests gated by target_pointer_width.
  • Simplify the super imports in the allocator arena unit tests accordingly.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Apr 24, 2026 •
edited
Loading

Merge activity

@overlookmotel
test(allocator): remove tests for size of ChunkFooter (#21734)
dfc2451 
Remove 2 tests for the size of `ChunkFooter`. It's not relevant, and doesn't require tests. These tests will fail if add more fields to `ChunkFooter`, which is a pain for no gain.
@graphite-app graphite-app Bot force-pushed the om/04-24-doc_allocator_improve_doc_comments_for_chunkfooter_ branch from 91c8cce to 93b7dbd Compare April 24, 2026 21:18
@graphite-app graphite-app Bot force-pushed the om/04-24-test_allocator_remove_tests_for_size_of_chunkfooter_ branch from ceaa3c5 to dfc2451 Compare April 24, 2026 21:18
Base automatically changed from om/04-24-doc_allocator_improve_doc_comments_for_chunkfooter_ to main April 24, 2026 21:25
@graphite-app graphite-app Bot merged commit dfc2451 into main Apr 24, 2026
38 checks passed
@graphite-app graphite-app Bot deleted the om/04-24-test_allocator_remove_tests_for_size_of_chunkfooter_ branch April 24, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-allocator Area - Allocator C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel