Skip to content

docs(ast_tools): correct doc comment for AstKind codegen#21683

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/02-14-docs_ast_tools_correct_doc_comment_for_astkind_codegen
Apr 23, 2026
Merged

docs(ast_tools): correct doc comment for AstKind codegen#21683
graphite-app[bot] merged 1 commit intomainfrom
om/02-14-docs_ast_tools_correct_doc_comment_for_astkind_codegen

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 23, 2026 •
edited
Loading

Just correct a doc comment, so it matches what the generator produces.

This was referenced Apr 23, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 23, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Apr 23, 2026
Merged
@overlookmotel overlookmotel self-assigned this Apr 23, 2026
This was referenced Apr 23, 2026
Merged
Merged
Merged
@overlookmotel overlookmotel added A-ast-tools Area - AST tools C-docs Category - Documentation. Related to user-facing or internal documentation labels Apr 23, 2026 — with Graphite App
@overlookmotel overlookmotel marked this pull request as ready for review April 23, 2026 14:01
Copilot AI review requested due to automatic review settings April 23, 2026 14:01
Copilot AI reviewed Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the AstKind generator module-level documentation so it accurately reflects the methods the generator emits, aligning developer-facing docs with the generated AstKind API.

Changes:

  • Document that AstKind codegen includes AstKind::node_id and AstKind::set_node_id methods.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Apr 23, 2026 •
edited
Loading

Merge activity

@graphite-app graphite-app Bot force-pushed the om/02-14-refactor_ast_repurpose_commentnodeid_code_in_astbuilder_codegen_for_nodeid_ branch from aa172b8 to 8a2ad95 Compare April 23, 2026 15:38
graphite-app Bot pushed a commit that referenced this pull request Apr 23, 2026
@overlookmotel
docs(ast_tools): correct doc comment for AstKind codegen (#21683)
2fba253 
Just correct a doc comment, so it matches what the generator produces.
@graphite-app graphite-app Bot force-pushed the om/02-14-docs_ast_tools_correct_doc_comment_for_astkind_codegen branch from 977d89e to 2fba253 Compare April 23, 2026 15:39
@graphite-app graphite-app Bot force-pushed the om/02-14-refactor_ast_repurpose_commentnodeid_code_in_astbuilder_codegen_for_nodeid_ branch from 8a2ad95 to b26c4a4 Compare April 23, 2026 15:49
graphite-app Bot pushed a commit that referenced this pull request Apr 23, 2026
@overlookmotel
docs(ast_tools): correct doc comment for AstKind codegen (#21683)
8937d6b 
Just correct a doc comment, so it matches what the generator produces.
@graphite-app graphite-app Bot force-pushed the om/02-14-docs_ast_tools_correct_doc_comment_for_astkind_codegen branch from 2fba253 to 8937d6b Compare April 23, 2026 15:49
@graphite-app graphite-app Bot force-pushed the om/02-14-refactor_ast_repurpose_commentnodeid_code_in_astbuilder_codegen_for_nodeid_ branch from b26c4a4 to cf6da3e Compare April 23, 2026 17:23
graphite-app Bot pushed a commit that referenced this pull request Apr 23, 2026
@overlookmotel
docs(ast_tools): correct doc comment for AstKind codegen (#21683)
c5d23e4 
Just correct a doc comment, so it matches what the generator produces.
@graphite-app graphite-app Bot force-pushed the om/02-14-docs_ast_tools_correct_doc_comment_for_astkind_codegen branch from 8937d6b to c5d23e4 Compare April 23, 2026 17:23
@overlookmotel
docs(ast_tools): correct doc comment for AstKind codegen (#21683)
7c960d9 
Just correct a doc comment, so it matches what the generator produces.
@graphite-app graphite-app Bot force-pushed the om/02-14-refactor_ast_repurpose_commentnodeid_code_in_astbuilder_codegen_for_nodeid_ branch from cf6da3e to eccbdfa Compare April 23, 2026 17:31
@graphite-app graphite-app Bot force-pushed the om/02-14-docs_ast_tools_correct_doc_comment_for_astkind_codegen branch from c5d23e4 to 7c960d9 Compare April 23, 2026 17:32
Base automatically changed from om/02-14-refactor_ast_repurpose_commentnodeid_code_in_astbuilder_codegen_for_nodeid_ to main April 23, 2026 18:46
@graphite-app graphite-app Bot merged commit 7c960d9 into main Apr 23, 2026
26 checks passed
@graphite-app graphite-app Bot deleted the om/02-14-docs_ast_tools_correct_doc_comment_for_astkind_codegen branch April 23, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-ast-tools Area - AST tools C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel