refactor(ast_tools): remove special-case logic for NodeId from ESTree generator#21678
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 23, 2026
Conversation
This was referenced Apr 23, 2026
Member
Author
This was referenced Apr 23, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the ESTree generator logic in tasks/ast_tools by removing a hard-coded “skip node_id by name” special case and instead relying on schema-driven #[estree(skip)] metadata attached to the NodeId type.
Changes:
- Removed the
field.name() == "node_id"special-case fromshould_skip_field. - Marked
oxc_syntax::node::NodeIdwith#[estree(skip)]so any fields containingNodeIdare skipped via the existing type-based skip path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tasks/ast_tools/src/derives/estree.rs | Removes the node_id name-based skip and relies on existing “innermost type has #[estree(skip)]” logic. |
| crates/oxc_syntax/src/node.rs | Adds #[estree(skip)] to NodeId so Cell<NodeId> (and other wrappers) are skipped consistently by generators using should_skip_field. |
a30b94f to
786fcd5
Compare
89eeb44 to
6c09f85
Compare
This was referenced Apr 23, 2026
Contributor
Merge activity
|
786fcd5 to
ed660cf
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Apr 23, 2026
…ree` generator (#21678) Simplify `ESTree` generator in `ast_tools`. Previously it had "special case" code for `NodeId`. Instead, add a `#[estree(skip)]` attr to `NodeId` type, and then `node_id: Cell<NodeId>` fields can be treated the same as any other field. Does not alter generated code, only the means by which it's generated.
6c09f85 to
459e860
Compare
ed660cf to
f30e3c2
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Apr 23, 2026
…ree` generator (#21678) Simplify `ESTree` generator in `ast_tools`. Previously it had "special case" code for `NodeId`. Instead, add a `#[estree(skip)]` attr to `NodeId` type, and then `node_id: Cell<NodeId>` fields can be treated the same as any other field. Does not alter generated code, only the means by which it's generated.
459e860 to
545209c
Compare
f30e3c2 to
ea3bfd8
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Apr 23, 2026
…ree` generator (#21678) Simplify `ESTree` generator in `ast_tools`. Previously it had "special case" code for `NodeId`. Instead, add a `#[estree(skip)]` attr to `NodeId` type, and then `node_id: Cell<NodeId>` fields can be treated the same as any other field. Does not alter generated code, only the means by which it's generated.
545209c to
6adf026
Compare
…ree` generator (#21678) Simplify `ESTree` generator in `ast_tools`. Previously it had "special case" code for `NodeId`. Instead, add a `#[estree(skip)]` attr to `NodeId` type, and then `node_id: Cell<NodeId>` fields can be treated the same as any other field. Does not alter generated code, only the means by which it's generated.
ea3bfd8 to
aad7d98
Compare
6adf026 to
1a9e967
Compare
Base automatically changed from
om/02-14-refactor_ast_tools_remove_special-case_logic_for_nodeid_from_contenteq_generator
to
main
April 23, 2026 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify
ESTreegenerator inast_tools.Previously it had "special case" code for
NodeId. Instead, add a#[estree(skip)]attr toNodeIdtype, and thennode_id: Cell<NodeId>fields can be treated the same as any other field.Does not alter generated code, only the means by which it's generated.