fix(transformer/typescript): preserve computed-key static block when class has an empty constructor#21562
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 20, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merging this PR will not alter performance
Comparing Footnotes
|
Member
Author
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
…class has an empty constructor (#21562) ## Summary When a TypeScript class used a computed-key static property together with a constructor that has no parameter-property assignments, the early return in `transform_class_fields` dropped the `computed_key_assignment_static_block` that initializes the temp var, leaving it declared but never assigned. ```ts export class SampleClass { static [Symbol.toPrimitive] = "test" constructor() {} } ``` previously emitted: ```js let _Symbol$toPrimitive; export class SampleClass { static { this[_Symbol$toPrimitive] = "test"; } constructor() {} } ``` Now emits (matching TypeScript's own output under `useDefineForClassFields: false`): ```js let _Symbol$toPrimitive; export class SampleClass { static { _Symbol$toPrimitive = Symbol.toPrimitive; } static { this[_Symbol$toPrimitive] = "test"; } constructor() {} } ``` ## Test plan - Added fixtures `computed-static-property-with-constructor` (exact repro) and `computed-static-property-with-constructor-super` (super() + multiple computed keys) under `babel-plugin-transform-typescript`. - Verified output against `tsc` 5.7 with `useDefineForClassFields: false`. Closes rolldown/rolldown#9121
fd738c7 to
eac25b1
Compare
eac25b1 to
a422954
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
…class has an empty constructor (#21562) ## Summary When a TypeScript class used a computed-key static property together with a constructor that has no parameter-property assignments, the early return in `transform_class_fields` dropped the `computed_key_assignment_static_block` that initializes the temp var, leaving it declared but never assigned. ```ts export class SampleClass { static [Symbol.toPrimitive] = "test" constructor() {} } ``` previously emitted: ```js let _Symbol$toPrimitive; export class SampleClass { static { this[_Symbol$toPrimitive] = "test"; } constructor() {} } ``` Now emits (matching TypeScript's own output under `useDefineForClassFields: false`): ```js let _Symbol$toPrimitive; export class SampleClass { static { _Symbol$toPrimitive = Symbol.toPrimitive; } static { this[_Symbol$toPrimitive] = "test"; } constructor() {} } ``` ## Test plan - Added fixtures `computed-static-property-with-constructor` (exact repro) and `computed-static-property-with-constructor-super` (super() + multiple computed keys) under `babel-plugin-transform-typescript`. - Verified output against `tsc` 5.7 with `useDefineForClassFields: false`. Closes rolldown/rolldown#9121
a422954 to
fc65ced
Compare
graphite-app Bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
…class has an empty constructor (#21562) ## Summary When a TypeScript class used a computed-key static property together with a constructor that has no parameter-property assignments, the early return in `transform_class_fields` dropped the `computed_key_assignment_static_block` that initializes the temp var, leaving it declared but never assigned. ```ts export class SampleClass { static [Symbol.toPrimitive] = "test" constructor() {} } ``` previously emitted: ```js let _Symbol$toPrimitive; export class SampleClass { static { this[_Symbol$toPrimitive] = "test"; } constructor() {} } ``` Now emits (matching TypeScript's own output under `useDefineForClassFields: false`): ```js let _Symbol$toPrimitive; export class SampleClass { static { _Symbol$toPrimitive = Symbol.toPrimitive; } static { this[_Symbol$toPrimitive] = "test"; } constructor() {} } ``` ## Test plan - Added fixtures `computed-static-property-with-constructor` (exact repro) and `computed-static-property-with-constructor-super` (super() + multiple computed keys) under `babel-plugin-transform-typescript`. - Verified output against `tsc` 5.7 with `useDefineForClassFields: false`. Closes rolldown/rolldown#9121
fc65ced to
06687ed
Compare
…class has an empty constructor (#21562) ## Summary When a TypeScript class used a computed-key static property together with a constructor that has no parameter-property assignments, the early return in `transform_class_fields` dropped the `computed_key_assignment_static_block` that initializes the temp var, leaving it declared but never assigned. ```ts export class SampleClass { static [Symbol.toPrimitive] = "test" constructor() {} } ``` previously emitted: ```js let _Symbol$toPrimitive; export class SampleClass { static { this[_Symbol$toPrimitive] = "test"; } constructor() {} } ``` Now emits (matching TypeScript's own output under `useDefineForClassFields: false`): ```js let _Symbol$toPrimitive; export class SampleClass { static { _Symbol$toPrimitive = Symbol.toPrimitive; } static { this[_Symbol$toPrimitive] = "test"; } constructor() {} } ``` ## Test plan - Added fixtures `computed-static-property-with-constructor` (exact repro) and `computed-static-property-with-constructor-super` (super() + multiple computed keys) under `babel-plugin-transform-typescript`. - Verified output against `tsc` 5.7 with `useDefineForClassFields: false`. Closes rolldown/rolldown#9121
06687ed to
91e5bde
Compare
camc314
added a commit
that referenced
this pull request
Apr 20, 2026
### 🐛 Bug Fixes - 48967e8 isolated_declarations: Drop required type check for private parameter properties on private constructors (#21515) (Dunqing) - 91e5bde transformer/typescript: Preserve computed-key static block when class has an empty constructor (#21562) (Dunqing) - 50e9d26 mangler: Assign correct slot to shadowed function-expression names (#21535) (Dunqing) - 065ce47 isolated_declarations: Collect types from private accessors for paired inference (#21516) (Dunqing) - 00fc136 codegen: Preserve coverage comments before object properties (#21312) (bab) - d676e0c minifier: Mark LHS of `??=` as read when converting from `== null &&` (#21546) (Gunnlaugur Thor Briem) ### ⚡ Performance - e45efc5 parser: Reduce `try_parse` usage in favour of `lookahead` (#21532) (Boshen) - ddb1bf8 parser: Avoid redundant `IdentifierReference` clone in shorthand property (#21511) (Boshen) - be2b392 allocator: Store pointers directly in `Arena` (#21483) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: Cameron <cameron.clark@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
When a TypeScript class used a computed-key static property together with a constructor that has no parameter-property assignments, the early return in
transform_class_fieldsdropped thecomputed_key_assignment_static_blockthat initializes the temp var, leaving it declared but never assigned.previously emitted:
Now emits (matching TypeScript's own output under
useDefineForClassFields: false):Test plan
computed-static-property-with-constructor(exact repro) andcomputed-static-property-with-constructor-super(super() + multiple computed keys) underbabel-plugin-transform-typescript.tsc5.7 withuseDefineForClassFields: false.Closes rolldown/rolldown#9121