fix(isolated_declarations): drop required type check for private parameter properties on private constructors#21515
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 20, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
prefer-dom-node-remove rule (#21470)
Merging this PR will not alter performance
Comparing Footnotes
|
44bf75d to
aed63e8
Compare
Member
Author
Merge activity
|
aed63e8 to
ee38f92
Compare
ee38f92 to
33b0609
Compare
…meter properties on private constructors (#21515) ## Summary A private parameter property on a private constructor doesn't need an explicit type annotation: - The constructor signature is collapsed to `private constructor();` — the parameter is never emitted. - The parameter-property class member is emitted as `private readonly name;` — type-erased. Since the parameter's type does not appear in the `.d.ts` output in either place, no type is needed. This matches `tsc --isolatedDeclarations`. Non-private parameter properties on a private constructor still require a type, because the class member keeps the type. ## Example ```ts export class GreyhoundServer { private constructor( private readonly logger = new ConsoleLogger(['greyhound-server']), ) {} } ``` Before: `TS9011: Parameter must have an explicit type annotation`. After: no error — emits `private readonly logger;` and `private constructor();`, matching tsc. ## Test plan - [x] Added snapshot fixtures covering both the no-error case (private param property) and the still-errors case (public param property on private constructor) - [x] `cargo test -p oxc_isolated_declarations` Closes #21503 (case 1)
33b0609 to
48967e8
Compare
camc314
added a commit
that referenced
this pull request
Apr 20, 2026
### 🐛 Bug Fixes - 48967e8 isolated_declarations: Drop required type check for private parameter properties on private constructors (#21515) (Dunqing) - 91e5bde transformer/typescript: Preserve computed-key static block when class has an empty constructor (#21562) (Dunqing) - 50e9d26 mangler: Assign correct slot to shadowed function-expression names (#21535) (Dunqing) - 065ce47 isolated_declarations: Collect types from private accessors for paired inference (#21516) (Dunqing) - 00fc136 codegen: Preserve coverage comments before object properties (#21312) (bab) - d676e0c minifier: Mark LHS of `??=` as read when converting from `== null &&` (#21546) (Gunnlaugur Thor Briem) ### ⚡ Performance - e45efc5 parser: Reduce `try_parse` usage in favour of `lookahead` (#21532) (Boshen) - ddb1bf8 parser: Avoid redundant `IdentifierReference` clone in shorthand property (#21511) (Boshen) - be2b392 allocator: Store pointers directly in `Arena` (#21483) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: Cameron <cameron.clark@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
A private parameter property on a private constructor doesn't need an explicit type annotation:
private constructor();— the parameter is never emitted.private readonly name;— type-erased.Since the parameter's type does not appear in the
.d.tsoutput in either place, no type is needed. This matchestsc --isolatedDeclarations. Non-private parameter properties on a private constructor still require a type, because the class member keeps the type.Example
Before:
TS9011: Parameter must have an explicit type annotation.After: no error — emits
private readonly logger;andprivate constructor();, matching tsc.Test plan
cargo test -p oxc_isolated_declarationsCloses #21503 (case 1)