refactor(allocator): route all Bump creation through Bump::new_impl function#21341
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 12, 2026
Conversation
This was referenced Apr 12, 2026
Member
Author
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors oxc_allocator::bump::Bump construction to go through a single internal helper (Bump::new_impl), reducing duplicated initialization logic and preparing for follow-up work to centralize allocation tracking inside Bump (per #21342).
Changes:
- Introduced
Bump::new_impl(chunk_footer_ptr, allocation_limit)as the centralized initializer. - Updated
with_min_align,try_with_min_align_and_capacity(capacity==0 and normal path), andfrom_raw_partsto usenew_implinstead of struct literals.
Contributor
Merge activity
|
…l` function (#21341) Pure refactor. Add a helper function `Bump::new_impl`which creates a `Bump`. Use that helper instead of constructing `Bump`s directly in various places. This has little benefit in itself, but reduces the amount of repeated code required to move allocation tracking into `Bump` (next PR #21342).
c3603c0 to
36f505f
Compare
ecc4100 to
9129a0a
Compare
Base automatically changed from
om/04-12-fix_allocator_stringbuilder_use_allocator_alloc_layout_
to
main
April 12, 2026 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Add a helper function
Bump::new_implwhich creates aBump. Use that helper instead of constructingBumps directly in various places. This has little benefit in itself, but reduces the amount of repeated code required to move allocation tracking intoBump(next PR #21342).