refactor(str): introduce LenAndHash abstraction#21244
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
This was referenced Apr 9, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 9, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
4071989 to
d56dc8e
Compare
0c30698 to
403b9f6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors oxc_str::Ident by introducing an internal LenAndHash abstraction to encapsulate the platform-specific representation of identifier length and precomputed hash, reducing #[cfg] duplication while preserving the optimized layout (including 12-byte Ident on 32-bit targets).
Changes:
- Introduce a
LenAndHashtype with 64-bit (packedu64) and non-64-bit ({ len: u32, hash: u32 }) implementations. - Replace
Ident’s platform-conditionallen/hashfields with a singlelen_and_hash: LenAndHash, simplifyingfrom_raw, length/hash accessors,Eq, andHash.
403b9f6 to
fc493c6
Compare
Contributor
Merge activity
|
Refactor to `Ident`. `len` and `hash` fields are stored packed as a single `u64` on 64-bit platforms, but as 2 separate `u32`s on 32-bit. This reduces size of `Ident` to 12 bytes on 32-bit. Introduce a `LenAndHash` struct which abstracts away this platform difference, so that all other methods can be written once, rather than having to have separate `#[cfg(target_pointer_width = "64")]` and `#[cfg(not(target_pointer_width = "64"))]` implementations, which need to be kept in sync with each other.
d56dc8e to
8cc87db
Compare
fc493c6 to
5e407e2
Compare
Base automatically changed from
om/04-09-refactor_str_move_display_impl_to_before_debug_impl
to
main
April 9, 2026 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor to
Ident.lenandhashfields are stored packed as a singleu64on 64-bit platforms, but as 2 separateu32s on 32-bit. This reduces size ofIdentto 12 bytes on 32-bit.Introduce a
LenAndHashstruct which abstracts away this platform difference, so that all other methods can be written once, rather than having to have separate#[cfg(target_pointer_width = "64")]and#[cfg(not(target_pointer_width = "64"))]implementations, which need to be kept in sync with each other.