Skip to content

refactor(str): import traits at top level#21243

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-08-refactor_str_import_traits_at_top_level
Apr 9, 2026
Merged

refactor(str): import traits at top level#21243
graphite-app[bot] merged 1 commit intomainfrom
om/04-08-refactor_str_import_traits_at_top_level

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 9, 2026 •
edited
Loading

Pure refactor. Shorten and simplify code by importing traits like Display at top level.

This was referenced Apr 9, 2026
Merged
Merged
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 9, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Apr 9, 2026
Merged
Merged
Merged
@github-actions github-actions Bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Apr 9, 2026
@overlookmotel overlookmotel mentioned this pull request Apr 9, 2026
Merged
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 9, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing om/04-08-refactor_str_import_traits_at_top_level (24e9ee5) with main (f134e24)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (04b3c2f) during the generation of this report, so f134e24 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@overlookmotel overlookmotel marked this pull request as ready for review April 9, 2026 10:52
Copilot AI review requested due to automatic review settings April 9, 2026 10:52
@overlookmotel overlookmotel force-pushed the om/04-08-refactor_str_import_traits_at_top_level branch from 4071989 to 0c1e834 Compare April 9, 2026 10:53
@overlookmotel overlookmotel mentioned this pull request Apr 9, 2026
Merged
@overlookmotel overlookmotel self-assigned this Apr 9, 2026
Copilot AI reviewed Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors oxc_str::Ident’s standard library imports to bring commonly used traits (Debug, Display, Hash, Hasher) into scope at the top level, reducing module-qualified paths in impl blocks.

Changes:

  • Replaces std::{fmt, hash, ...} with explicit fmt::{self, Debug, Display} and hash::{Hash, Hasher} imports.
  • Updates trait impl headers and generic bounds to use the newly imported trait names (impl Hash, H: Hasher, impl Debug, impl Display).

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Apr 9, 2026 •
edited
Loading

Merge activity

@overlookmotel
refactor(str): import traits at top level (#21243)
24e9ee5 
Pure refactor. Shorten and simplify code by importing traits like `Display` at top level.
@graphite-app graphite-app Bot force-pushed the om/04-08-fix_str_fix_unsound_casting_const_pointers_to_mut_pointers branch from 4ef0b35 to 04b3c2f Compare April 9, 2026 12:07
@graphite-app graphite-app Bot force-pushed the om/04-08-refactor_str_import_traits_at_top_level branch from 0c1e834 to 24e9ee5 Compare April 9, 2026 12:08
Base automatically changed from om/04-08-fix_str_fix_unsound_casting_const_pointers_to_mut_pointers to main April 9, 2026 12:14
@graphite-app graphite-app Bot merged commit 24e9ee5 into main Apr 9, 2026
36 checks passed
@graphite-app graphite-app Bot deleted the om/04-08-refactor_str_import_traits_at_top_level branch April 9, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel