fix(ast_tools): correct error message and doc comment#20930
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 1, 2026
Merged
fix(ast_tools): correct error message and doc comment#20930graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates an ESTree schema extension doc comment to reflect newer AST string-like types (notably Ident) used by ast_tools, keeping developer-facing documentation accurate after recent type introductions.
Changes:
- Update
ESTreeStructField::json_safedoc comment to includeIdentandOption<...>variants. - Minor punctuation/formatting improvement in the updated doc comment.
4781316 to
a718529
Compare
Contributor
Merge activity
|
Correct an incorrect error message, and a doc comment which was out of date after the introduction of `Ident` type.
2770276 to
15546c0
Compare
a718529 to
2a28e4c
Compare
Base automatically changed from
om/04-01-refactor_napi_parser_linter_plugins_shorten_raw_transfer_deserializers_for_option_s
to
main
April 1, 2026 12:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct an incorrect error message, and a doc comment which was out of date after the introduction of
Identtype.