refactor(napi/parser, linter/plugins): shorten raw transfer deserializers for Options#20924
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 1, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the raw-transfer JS deserializer codegen to emit a shorter Option deserialization pattern, then updates the generated deserializer outputs for the NAPI parser and oxlint JS bundles accordingly.
Changes:
- Update
generate_optionin the raw-transfer generator to use a single ternaryreturninstead of anif+return. - Regenerate
napi/parserJS deserializer artifacts to reflect the newOptionpattern. - Regenerate
apps/oxlintJS deserializer artifact to reflect the newOptionpattern.
Reviewed changes
Copilot reviewed 1 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/ast_tools/src/generators/raw_transfer.rs | Updates Option deserializer codegen to a ternary return form. |
| napi/parser/src-js/generated/deserialize/ts.js | Regenerated TS deserializer output with shortened Option functions. |
| napi/parser/src-js/generated/deserialize/ts_range.js | Regenerated TS (range) deserializer output with shortened Option functions. |
| napi/parser/src-js/generated/deserialize/ts_range_parent.js | Regenerated TS (range+parent) deserializer output with shortened Option functions. |
| napi/parser/src-js/generated/deserialize/ts_parent.js | Regenerated TS (parent) deserializer output with shortened Option functions. |
| napi/parser/src-js/generated/deserialize/js.js | Regenerated JS deserializer output with shortened Option functions. |
| napi/parser/src-js/generated/deserialize/js_range.js | Regenerated JS (range) deserializer output with shortened Option functions. |
| napi/parser/src-js/generated/deserialize/js_range_parent.js | Regenerated JS (range+parent) deserializer output with shortened Option functions. |
| napi/parser/src-js/generated/deserialize/js_parent.js | Regenerated JS (parent) deserializer output with shortened Option functions. |
| apps/oxlint/src-js/generated/deserialize.js | Regenerated oxlint deserializer output with shortened Option functions. |
1ba5af3 to
3170f01
Compare
a89d62e to
2770276
Compare
This was referenced Apr 1, 2026
Contributor
Merge activity
|
…zers for `Option`s (#20924) Refactor. Just shorten the code generated for deserializing `Option`s in raw transfer deserializer.
3170f01 to
0503a78
Compare
2770276 to
15546c0
Compare
Base automatically changed from
om/04-01-perf_napi_parser_linter_plugins_faster_deserialization_of_raw_fields
to
main
April 1, 2026 12:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor. Just shorten the code generated for deserializing
Options in raw transfer deserializer.