test(linter/plugins): fix impliedStrict in ES3#18635
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of strict mode in ES3 conformance tests. Since strict mode was introduced in ES5 and did not exist in ES3, the code now correctly sets impliedStrict to false when testing with ES3, ensuring accurate scope analysis for historical ECMAScript versions.
Changes:
- Modified
setEcmaVersionAndFeaturesto check ifecmaVersion === 3and forceimpliedStricttofalsein that case
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|
Fix strict/sloppy mode of scopes in conformance tests where test case options specify ES3. Strict mode did not exist before ES5, so files are always sloppy mode in ES3.
d37831a to
af233a5
Compare
c2f4cc5 to
4e08b91
Compare
Fix strict/sloppy mode of scopes in conformance tests where test case options specify ES3. Strict mode did not exist before ES5, so files are always sloppy mode in ES3.