test(linter/plugins): fix ecmaVersion#18634
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 27, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects how context.languageOptions.ecmaVersion is derived for conformance tests so it matches ESLint’s behavior, particularly when tests specify ES3 or ES5.
Changes:
- Replace the previous blanket conversion of numeric
ecmaVersionvalues< 2015with logic that only maps6–17to2015–2026, leaving3and5unchanged as in ESLint. - Default
ecmaVersiontoECMA_VERSIONwhen it is missing or non-numeric, preserving existing behavior for undefined /"latest"while fixing the ES3/ES5 mismatch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
Fix `context.languageOptions.ecmaVersion` in conformance tests. Previously it did not match ESLint when test case options specify ES3 or ES5.
d37831a to
af233a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
context.languageOptions.ecmaVersionin conformance tests. Previously it did not match ESLint when test case options specify ES3 or ES5.