test(linter/plugins): conformance tester set default export on parser modules#18553
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 25, 2026
Conversation
This was referenced Jan 25, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a workaround for a bug in tsx where ESM code importing CommonJS modules (specifically parser modules like @typescript-eslint/parser) can malfunction. The fix adds a default property to parser modules to work around this issue.
Changes:
- Added a default export property to parser modules loaded by the conformance tester
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ca2d841 to
e07c667
Compare
94e1803 to
da1199c
Compare
Contributor
Merge activity
|
… modules (#18553) Conformance tester is run with `tsx` to support test files written in TS. `tsx` seems to sometimes malfunction where ESM code `import`s CommonJS modules (like parsers e.g. `@typescript-eslint/parser`. Add a `default` property to parser modules, to solve this problem.
da1199c to
886ac2f
Compare
e07c667 to
da76bc5
Compare
Base automatically changed from
om/01-25-test_linter_plugins_conformance_test_snapshots_include_parser_details
to
main
January 25, 2026 22:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conformance tester is run with
tsxto support test files written in TS.tsxseems to sometimes malfunction where ESM codeimports CommonJS modules (like parsers e.g.@typescript-eslint/parser. Add adefaultproperty to parser modules, to solve this problem.