test(linter/plugins): conformance test snapshots include parser details#18552
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 25, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the conformance tester snapshots to record which parser (and associated details) was used for each test case, making parser-specific failures easier to reproduce.
Changes:
- Add
_parsermetadata onto captured test cases for snapshot output. - Replace parser-to-language maps with parser-to-
ParserDetailsmaps. - Introduce a shared
ParserDetailsinterface and use it inTestGroup.parsers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| apps/oxlint/conformance/src/rule_tester.ts | Captures/stores parser metadata on test cases and switches parser maps to ParserDetails. |
| apps/oxlint/conformance/src/index.ts | Defines ParserDetails and updates group parser configuration to use it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b23c5cd to
f7300b9
Compare
94e1803 to
da1199c
Compare
Contributor
Merge activity
|
…ls (#18552) Include details of what parser test cases are parsed with in conformance test snapshots, to make it easier to reproduce bugs.
f7300b9 to
1685ceb
Compare
da1199c to
886ac2f
Compare
Base automatically changed from
om/01-25-test_linter_plugins_conformance_tests_remove_duplicate_check
to
main
January 25, 2026 21:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include details of what parser test cases are parsed with in conformance test snapshots, to make it easier to reproduce bugs.