Skip to content

fix(minifier)!: receive supported engines instead of ecmascript versions#13933

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-19-fix_minifier_receive_supported_engines_instead_of_ecmascript_versions
Sep 20, 2025
Merged

fix(minifier)!: receive supported engines instead of ecmascript versions#13933
graphite-app[bot] merged 1 commit intomainfrom
09-19-fix_minifier_receive_supported_engines_instead_of_ecmascript_versions

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Sep 19, 2025 •
edited
Loading

fixes #8905

@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Sep 19, 2025
@sapphi-red sapphi-red mentioned this pull request Sep 19, 2025
Merged
@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Sep 19, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red mentioned this pull request Sep 19, 2025
Merged
@sapphi-red sapphi-red force-pushed the 09-19-fix_minifier_receive_supported_engines_instead_of_ecmascript_versions branch from 0b100f9 to 3ed2b14 Compare September 19, 2025 18:02
@sapphi-red sapphi-red force-pushed the 09-19-feat_compat_extract_compatibility_data_to_oxc_compat_crate branch from 8ddb4f6 to e760d29 Compare September 19, 2025 18:02
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 19, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #13933 will degrade performances by 3.02%

Comparing 09-19-fix_minifier_receive_supported_engines_instead_of_ecmascript_versions (6fcb0d0) with main (b2b2037)1

Summary

❌ 1 regression
✅ 36 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ minifier[cal.com.tsx] 31.1 ms 32.1 ms -3.02%

Footnotes

  1. No successful run was found on main (6fcb0d0) during the generation of this report, so b2b2037 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@sapphi-red sapphi-red force-pushed the 09-19-fix_minifier_receive_supported_engines_instead_of_ecmascript_versions branch 2 times, most recently from 559644c to 56d2e30 Compare September 20, 2025 13:17
@sapphi-red sapphi-red force-pushed the 09-19-feat_compat_extract_compatibility_data_to_oxc_compat_crate branch from e760d29 to 861d142 Compare September 20, 2025 13:17
@sapphi-red sapphi-red requested a review from Boshen September 20, 2025 13:26
@sapphi-red sapphi-red marked this pull request as ready for review September 20, 2025 13:26
@sapphi-red sapphi-red force-pushed the 09-19-fix_minifier_receive_supported_engines_instead_of_ecmascript_versions branch from 56d2e30 to 90a6b0d Compare September 20, 2025 13:31
@sapphi-red sapphi-red force-pushed the 09-19-feat_compat_extract_compatibility_data_to_oxc_compat_crate branch from 861d142 to ad94af5 Compare September 20, 2025 13:31
@graphite-app graphite-app bot force-pushed the 09-19-feat_compat_extract_compatibility_data_to_oxc_compat_crate branch from ad94af5 to c18cf12 Compare September 20, 2025 13:45
@graphite-app graphite-app bot force-pushed the 09-19-feat_compat_extract_compatibility_data_to_oxc_compat_crate branch from c18cf12 to 862b34f Compare September 20, 2025 13:46
@graphite-app graphite-app bot force-pushed the 09-19-fix_minifier_receive_supported_engines_instead_of_ecmascript_versions branch from 90a6b0d to 523cec4 Compare September 20, 2025 13:46
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 20, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Sep 20, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 09-19-feat_compat_extract_compatibility_data_to_oxc_compat_crate branch from 862b34f to d1a0d04 Compare September 20, 2025 14:41
@graphite-app graphite-app bot force-pushed the 09-19-fix_minifier_receive_supported_engines_instead_of_ecmascript_versions branch from 523cec4 to 6fcb0d0 Compare September 20, 2025 14:42
Base automatically changed from 09-19-feat_compat_extract_compatibility_data_to_oxc_compat_crate to main September 20, 2025 14:47
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 20, 2025
@graphite-app graphite-app bot merged commit 6fcb0d0 into main Sep 20, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 09-19-fix_minifier_receive_supported_engines_instead_of_ecmascript_versions branch September 20, 2025 14:48
This was referenced Sep 21, 2025
Merged
Closed
Merged
@sapphi-red sapphi-red mentioned this pull request Sep 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Awaiting requested review from Boshen

@overlookmotel overlookmotel Awaiting requested review from overlookmotel

@Dunqing Dunqing Awaiting requested review from Dunqing

Assignees

@Boshen Boshen

Labels

A-minifier Area - Minifier C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

minifier: transformed then minified back

2 participants

@sapphi-red @Boshen