chore(devcontainer): tweak devcontainer options#13931
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
d900f50 to
880a07c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the devcontainer configuration to use a custom Dockerfile instead of a pre-built image and modifies the setup process for better tool management. The changes aim to ensure that all necessary commands work properly within the development container environment.
- Replaced the pre-built Rust image with a custom Dockerfile-based build
- Added a post-creation script to handle tool installation and setup
- Updated environment and mount configurations for improved development workflow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .devcontainer/Dockerfile | Adds custom Dockerfile with required system packages (just, cmake) and uv tool |
| .devcontainer/devcontainer.json | Updates configuration to use custom Dockerfile, adds new features and mounts, changes post-creation command |
| .devcontainer/postCreateCommand.sh | New script to handle cargo-binstall installation, npm package setup, and initialization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
880a07c to
78f4481
Compare
Merge activity
|
Tweaked the devcontainer options so that the commands work in the dev container.
78f4481 to
51a2c30
Compare
Tweaked the devcontainer options so that the commands work in the dev container.