refactor(editor): use always the provided language server#11115
Merged
graphite-app[bot] merged 1 commit intomainfrom May 18, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
approved these changes
May 18, 2025
Contributor
Merge activity
|
Now, the editor will not look into `node_modules` folder to use a custom `oxc_language_server`. The editor will always use the provided language server. ## Reasons Because the language server in `node_modules` could be a different version than the extension and changes like #10890 can break the communication between them. Avoiding the JS Wrapper and resolving #9925 and avoiding a new setting #11018 closes #9925 closes #11018
e84da43 to
a28fe1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, the editor will not look into
node_modulesfolder to use a customoxc_language_server.The editor will always use the provided language server.
Reasons
Because the language server in
node_modulescould be a different version than the extension and changes like #10890 can break the communication between them.Avoiding the JS Wrapper and resolving #9925 and avoiding a new setting #11018
closes #9925
closes #11018