Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
0106010 to
c1e2e63
Compare
c1e2e63 to
549e417
Compare
56e36fc to
87bf2a8
Compare
549e417 to
2dad462
Compare
8efbdef to
b93e4fd
Compare
|
@camc314 I could not get a crash with the following configuration: I looked into the ESLint VS Code plugin and the Not really sure if this will resolve the issue :/ |
b93e4fd to
dd7b9b6
Compare
editors/vscode/client/extension.ts
Outdated
| if (configService.vsCodeConfig.nodePath) { | ||
| outputChannel.info(`adding path to NODE_PATH: ${configService.vsCodeConfig.nodePath}`); | ||
| if (serverEnv.NODE_PATH) { | ||
| serverEnv.NODE_PATH = serverEnv.NODE_PATH.concat(path.delimiter, configService.vsCodeConfig.nodePath); |
There was a problem hiding this comment.
should we not be appending this to PATH ?
There was a problem hiding this comment.
for reference, TS extension calls child_process.spawn if a custom node path is provided
There was a problem hiding this comment.
Changed it to PATH.
I do not understand that some of VSCode users are using the node_modules language_server, which has the JS wrapper.
I am always using the direct binary with custom oxc.path.server or from the VSCode extension.
dd7b9b6 to
7d23fcb
Compare
7d23fcb to
8e576a0
Compare
Now, the editor will not look into `node_modules` folder to use a custom `oxc_language_server`. The editor will always use the provided language server. ## Reasons Because the language server in `node_modules` could be a different version than the extension and changes like #10890 can break the communication between them. Avoiding the JS Wrapper and resolving #9925 and avoiding a new setting #11018 closes #9925 closes #11018
closes #9925