fix: handle multiple non-nested braces and **/ in brace patterns#10
Merged
shulaoda merged 3 commits intooxc-project:mainfrom Feb 23, 2025
Merged
fix: handle multiple non-nested braces and **/ in brace patterns#10shulaoda merged 3 commits intooxc-project:mainfrom
**/ in brace patterns#10shulaoda merged 3 commits intooxc-project:mainfrom
Conversation
CodSpeed Performance ReportMerging #10 will not alter performanceComparing Summary
|
shulaoda
reviewed
Feb 22, 2025
**/ in brace patterns**/ in brace patterns
This was referenced Feb 23, 2025
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Feb 23, 2025
### Description Related to oxc-project/fast-glob#10 Fixed some matching issues.
graphite-app bot
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Feb 26, 2025
Related to oxc-project/fast-glob#10 Fixed some matching issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translated from oven-sh/bun#17516
**/at the beginning of patterns in braces.Minimized test cases:
glob-match also fails the second test.
fixtures/input.txtis a list of files from vscode v1.97.0. Thematch-pattern-{n}.txtfiles were generated with minimatch.