You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@brynne8 with this change, each pattern from your test matches exactly the expected count except for the last pattern "extensions/**/{browser,common,node}/{**/*[sS]ervice*,**/*[pP]rovider*}.ts" which continues to match 0 paths.
@brynne8 with this change, each pattern from your test matches exactly the expected count except for the last pattern "extensions/**/{browser,common,node}/{**/*[sS]ervice*,**/*[pP]rovider*}.ts" which continues to match 0 paths.
Wow. That's great. But why is the last pattern continues to match 0 paths? Is that because there's complex pattern (with globstar and stars) in braces?
But why is the last pattern continues to match 0 paths? Is that because there's complex pattern (with globstar and stars) in braces?
There was a bug matching **/ inside {}. I've pushed a fix, now the last pattern matches 3 times with "extensions/github-authentication/src/common/experimentationService.ts", "extensions/microsoft-authentication/src/browser/authProvider.ts", and "extensions/microsoft-authentication/src/node/authProvider.ts"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes #17512
fixes bugs in patterns with non-nested brace pairs with trailing characters, e.g.
"{a,b}/c/{d,e}/**/*est.ts"with input"a/c/d/one/two/three.test.ts".fixes bugs with
**/at the beginning of patterns in braces, e.g."{**/a,**/b}"with input"b".How did you verify your code works?
Added a test with patterns from #17512