Add authentication to updater #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| define('CURRENT_DIR', getcwd()); | ||
| } | ||
|
|
||
| session_start(); |
Member
There was a problem hiding this comment.
@LukasReschke please leave this in place. I use session to store info between ajax requests. :)
Member
Author
|
PS: The styling sucks. But this is something that we or @jancborchardt can fix later 🙈 |
Member
|
@LukasReschke as or me I just steal markup and assets from core 🃏 |
396eadb to
56b8989
Compare
This adds some authentication to the updater using a shared secret in `config.php`. The whole process is cookieless and thus if somebody closes the tab all authentication is gone (which is desired from a security PoV) To test this define an `updater.secret` in `config.php` and try to access it with a valid or invalid token. The next step is to add the automagic login from core once this is in. We can do that using the new updatenotification app at owncloud/core#22238.
56b8989 to
1476048
Compare
Member
|
@LukasReschke You're magician! |
LukasReschke
added a commit
that referenced
this pull request
Feb 9, 2016
Add authentication to updater
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some authentication to the updater using a shared secret in
config.php. The whole process is cookieless and thus if somebody closes the tab all authentication is gone (which is desired from a security PoV)To test this define an
updater.secretinconfig.phpand try to access it with a valid or invalid token.The next step is to add the automagic login from core once this is in. We can do that using the new updatenotification app at owncloud/core#22238.
@VicDeo Please review.