Skip to content

Move update notification code into app #22238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LukasReschke merged 1 commit into from
Feb 9, 2016
Merged

Move update notification code into app #22238

LukasReschke merged 1 commit into from
Feb 9, 2016

Conversation

@LukasReschke
Copy link
Member

@LukasReschke LukasReschke commented Feb 9, 2016

Moves the update notification code in a single app. This is required since we want to use SSO for the new updater and for this have some code running in ownCloud as well (and we don't want that in core necessarily). This app can provide that in the future, right now it's only the update notification itself. Will continue working on the SSO right away but wanted to keep the PR small.

Furthermore also makes some more code unit-testable...

This is for the following bar in the top:
2016-02-09_13-05-26

@karlitschek @VicDeo @DeepDiver1975 Please review.

@LukasReschke LukasReschke added this to the 9.0-current milestone Feb 9, 2016
@LukasReschke
Copy link
Member Author

LukasReschke commented Feb 9, 2016

So what the next step would be is to add some authentication magic into the app as well. Then we can use that for authentication in the new updater app (well, only the value in the session). The changes right now are basically just moving code out of core + unit tests.

@karlitschek
Copy link
Contributor

karlitschek commented Feb 9, 2016

makes sense 👍

@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Feb 9, 2016

https://ci.owncloud.org/job/ocs-api-integration-tests-ci/7226/console

Scenario: get enabled apps                           # /ssd/jenkins/workspace/ocs-api-integration-tests-ci/build/integration/features/provisioning-v1.feature:279
    Given As an "admin"                                # FeatureContext::asAn()
    When sending "GET" to "/cloud/apps?filter=enabled" # FeatureContext::sendingTo()
    Then the OCS status code should be "100"           # FeatureContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"           # FeatureContext::theHTTPStatusCodeShouldBe()
    And apps returned are                              # FeatureContext::theAppsShouldBe()
      | comments             |
      | dav                  |
      | federatedfilesharing |
      | files                |
      | files_sharing        |
      | files_trashbin       |
      | files_versions       |
      | provisioning_api     |
      | systemtags           |
      Failed asserting that two arrays are equal.
      --- Expected
      +++ Actual
      @@ @@
           8 => 'systemtags'
      +    9 => 'updatenotification'
       )

@LukasReschke LukasReschke mentioned this pull request Feb 9, 2016
Closed
@PVince81
Copy link
Contributor

PVince81 commented Feb 9, 2016

Code looks good 👍

LukasReschke added a commit to owncloud/updater that referenced this pull request Feb 9, 2016
@LukasReschke
Add authentication to updater
472eba2 
This adds some authentication to the updater using a shared secret in `config.php`. The whole process is cookieless and thus if somebody closes the tab all authentication is gone (which is desired from a security PoV)

To test this define an `updater.secret` in `config.php` and try to access it with a valid or invalid token.

The next step is to add the automagic login from core once this is in. We can do that using the new updatenotification app at owncloud/core#22238.
@LukasReschke LukasReschke mentioned this pull request Feb 9, 2016
Merged
LukasReschke added a commit to owncloud/updater that referenced this pull request Feb 9, 2016
@LukasReschke
Add authentication to updater
4fac751 
This adds some authentication to the updater using a shared secret in `config.php`. The whole process is cookieless and thus if somebody closes the tab all authentication is gone (which is desired from a security PoV)

To test this define an `updater.secret` in `config.php` and try to access it with a valid or invalid token.

The next step is to add the automagic login from core once this is in. We can do that using the new updatenotification app at owncloud/core#22238.
LukasReschke added a commit to owncloud/updater that referenced this pull request Feb 9, 2016
@LukasReschke
Add authentication to updater
f72a52e 
This adds some authentication to the updater using a shared secret in `config.php`. The whole process is cookieless and thus if somebody closes the tab all authentication is gone (which is desired from a security PoV)

To test this define an `updater.secret` in `config.php` and try to access it with a valid or invalid token.

The next step is to add the automagic login from core once this is in. We can do that using the new updatenotification app at owncloud/core#22238.
@LukasReschke
Move update notification code into app
abc675d 
Moves the update notification code in a single app. This is required since we want to use SSO for the new updater and for this have some code running in ownCloud as well (and we don't want that in core neccessarily). This app can provide that in the future, right now it's only the update notification itself. Will continue working on the SSO right away but wanted to keep the PR small.

Furthermore also makes some more code unit-testable...
LukasReschke added a commit that referenced this pull request Feb 9, 2016
@LukasReschke
Merge pull request #22238 from owncloud/add-link-to-updater
a39c759 
Move update notification code into app
@LukasReschke LukasReschke merged commit a39c759 into master Feb 9, 2016
@LukasReschke LukasReschke deleted the add-link-to-updater branch February 9, 2016 17:22
@LukasReschke LukasReschke mentioned this pull request Feb 9, 2016
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

4 - To release

Projects

None yet

Milestone

9.0

Development

Successfully merging this pull request may close these issues.

5 participants

@LukasReschke @karlitschek @DeepDiver1975 @PVince81