Skip to content

[Backport] fix: some notifications were translated wrong due to an empty l10n key#11984

Merged
mmattel merged 1 commit into
stable-8.0from
notifications_calltoaction_empty_stable8.0
Feb 2, 2026
Merged

[Backport] fix: some notifications were translated wrong due to an empty l10n key#11984
mmattel merged 1 commit into
stable-8.0from
notifications_calltoaction_empty_stable8.0

Conversation

@jvillafanez

Copy link
Copy Markdown
Member

The expected translatable message was empty, which caused the translation system to use the empty key, which contains "weird" unrelated data.
With the fix, if there is no translatable message, the related output will remain empty.

Description

Backport of #11979 to stable 8.0

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

The expected translatable message was empty, which caused the
translation system to use the empty key, which contains "weird"
unrelated data.
With the fix, if there is no translatable message, the related output
will remain empty.
@update-docs

update-docs Bot commented Jan 30, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jvillafanez jvillafanez changed the title fix: some notifications were translated wrong due to an empty l10n key [Backport] fix: some notifications were translated wrong due to an empty l10n key Jan 30, 2026
@jvillafanez

Copy link
Copy Markdown
Member Author

I think this doesn't need a changelog entry since the original PR already has one.

@sonarqubecloud

Copy link
Copy Markdown

@mmattel mmattel enabled auto-merge February 2, 2026 12:40
@mmattel mmattel merged commit 205817e into stable-8.0 Feb 2, 2026
4 of 5 checks passed
@mmattel mmattel deleted the notifications_calltoaction_empty_stable8.0 branch February 2, 2026 12:40
ownclouders pushed a commit that referenced this pull request Feb 2, 2026
…pty_stable8.0

[Backport] fix: some notifications were translated wrong due to an empty l10n key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants