fix: some notifications were translated wrong due to an empty l10n key#11979
Merged
Conversation
The expected translatable message was empty, which caused the translation system to use the empty key, which contains "weird" unrelated data. With the fix, if there is no translatable message, the related output will remain empty.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Contributor
|
Should this fix also go into 8.0 or just master? |
Member
Author
|
I guess @kobergj knows... |
kobergj
approved these changes
Jan 30, 2026
Contributor
|
@jvillafanez yes, I agree. Please backport to |
9 tasks
Member
Author
|
Backport in #11984 |
2403905
approved these changes
Feb 6, 2026
ownclouders
pushed a commit
that referenced
this pull request
Feb 6, 2026
fix: some notifications were translated wrong due to an empty l10n key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expected translatable message was empty, which caused the translation system to use the empty key, which contains "weird" unrelated data.
With the fix, if there is no translatable message, the related output will remain empty.
Description
Empty messages (from the notification's calls to action) were wrongly translated.
Right now, all the related messages have all the "required" fields, except the "call to action" which is empty in some of them. In case of an empty "call to action", oCIS won't display any translation for it (the rest of the fields will be translated and work normally)
Related Issue
#11908
Motivation and Context
Notification email could contain useless information.
How Has This Been Tested?
Manually tested following the reproduction steps in the related issue.
Tested just in Spanish. The previous behavior was reproduced and with the PR the related message doesn't appear.
Screenshots (if appropriate):
Types of changes
Checklist: