fix: add date sorting support to table columns#11198
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds chronological date sorting support to table columns, fixing an issue where dates were being sorted alphabetically instead of by their actual chronological order.
Changes:
- Added date parsing function supporting multiple common date formats (ISO, European, US) using
date-fns - Modified table sorting logic to detect and sort dates chronologically, numbers numerically, or text alphabetically
- Empty cells are now consistently moved to the end regardless of sort type
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I am interested in merging this but |
Oh no - sorry for overlooking it. I checked linting on our internal repo but missed it on this fork. Should be fixed now. Let me know if anything else needs changing. (and yes, sorry for the AI lazyness) |
|
I refactored a little so that ambiguous slash formats are considered depending on the users current locale |
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [outline/outline](https://github.com/outline/outline) | minor | `1.3.0` → `1.4.0` | --- ### Release Notes <details> <summary>outline/outline (outline/outline)</summary> ### [`v1.4.0`](https://github.com/outline/outline/releases/tag/v1.4.0) [Compare Source](outline/outline@v1.3.0...v1.4.0) #### What's Changed ##### Highlights - New **"Toggle blocks"** allow creating content that is collapsed by default in [#​8317](outline/outline#8317) - Table cells can now have a custom background color set in [#​10930](outline/outline#10930) - Search results are now highlighted in the document when navigating from search in [#​11262](outline/outline#11262) ##### Other improvements - A new Figma integration allows unfurling information about Figma links in documents by [@​hmacr](https://github.com/hmacr) in [#​11044](outline/outline#11044) - Added support for sorting dates in table columns by [@​lucawimmer](https://github.com/lucawimmer) in [#​11198](outline/outline#11198) - Document changes made through the API are now synced to clients in realtime in [#​11186](outline/outline#11186) - The rate limiter now prefers user ID over ip address for logged in sessions, prevents issues on larger office networks in [#​11215](outline/outline#11215) - The markdown importer now supports more file layouts in [#​11278](outline/outline#11278) ##### Fixes - Fixed some typos comments and messages by [@​NAM-MAN](https://github.com/NAM-MAN) in [#​11203](outline/outline#11203) - Fixed an issue where mentions would sometimes break when using drag and drop in a list in [#​11208](outline/outline#11208) - The edit diagram control no longer appears in read-only mode in [#​11207](outline/outline#11207) - Infinite recursion in `dd-trace` dependency causes memory issues in [#​11211](outline/outline#11211) - Imported content now gracefully handles HTTP links in [#​11210](outline/outline#11210) - Editor suggestions on mobile now uses a drawer in [#​11213](outline/outline#11213) - When importing markdown checkboxes are now supported in table cells in [#​11217](outline/outline#11217) - GCS uniform bucket-level access now supported by [@​maycuatroi1](https://github.com/maycuatroi1) in [#​11222](outline/outline#11222) - Fixed a hanging read stream handle causing excessive memory usage on export in [#​11237](outline/outline#11237) - Fixed mermaid diagrams do not render when pasting markdown in [#​11243](outline/outline#11243) - Remote edits no longer exit Mermaid editing state in [#​11244](outline/outline#11244) - Table row is now inserted correctly with merged first column cells in [#​11245](outline/outline#11245) - Allow http\:// loopback redirect URIs for native OAuth apps (RFC 8252) in [#​11255](outline/outline#11255) - "Split cell" option now works without accurate selection in [#​11256](outline/outline#11256) - Adding text below images is now easier as trailing paragraph is enforcedd by [@​RudraPrasad001](https://github.com/RudraPrasad001) in [#​11257](outline/outline#11257) - Tooltip in editor toolbar with submenu is now hidden when submenu is open in [#​11263](outline/outline#11263) - Non-platform passkeys such as Yubikey and mobile QRcode are now allowed in [#​11265](outline/outline#11265) - diagrams.net theme now matches editor theme by [@​Twometer](https://github.com/Twometer) in [#​11267](outline/outline#11267) - Custom emoji characters are now displayed correctly in TOC in [#​11275](outline/outline#11275) - Fixed an issue where the policy for documents restore was too broad in [#​11279](outline/outline#11279) - Passkey setup is now available to non-admin users by [@​Raphmatt](https://github.com/Raphmatt) in [#​11286](outline/outline#11286) #### New Contributors - [@​NAM-MAN](https://github.com/NAM-MAN) made their first contribution in [#​11203](outline/outline#11203) - [@​lucawimmer](https://github.com/lucawimmer) made their first contribution in [#​11198](outline/outline#11198) - [@​maycuatroi1](https://github.com/maycuatroi1) made their first contribution in [#​11222](outline/outline#11222) - [@​RudraPrasad001](https://github.com/RudraPrasad001) made their first contribution in [#​11257](outline/outline#11257) - [@​Twometer](https://github.com/Twometer) made their first contribution in [#​11267](outline/outline#11267) - [@​Raphmatt](https://github.com/Raphmatt) made their first contribution in [#​11286](outline/outline#11286) **Full Changelog**: <outline/outline@v1.3.0...v1.4.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi42OS4yIiwidXBkYXRlZEluVmVyIjoiNDIuNjkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiaW1hZ2UiXX0=--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/3546 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [outlinewiki/outline](https://github.com/outline/outline) | minor | `1.3.0` → `1.4.0` | --- ### Release Notes <details> <summary>outline/outline (outlinewiki/outline)</summary> ### [`v1.4.0`](https://github.com/outline/outline/releases/tag/v1.4.0) [Compare Source](outline/outline@v1.3.0...v1.4.0) ##### What's Changed ##### Highlights - New **"Toggle blocks"** allow creating content that is collapsed by default in [#​8317](outline/outline#8317) - Table cells can now have a custom background color set in [#​10930](outline/outline#10930) - Search results are now highlighted in the document when navigating from search in [#​11262](outline/outline#11262) ##### Other improvements - A new Figma integration allows unfurling information about Figma links in documents by [@​hmacr](https://github.com/hmacr) in [#​11044](outline/outline#11044) - Added support for sorting dates in table columns by [@​lucawimmer](https://github.com/lucawimmer) in [#​11198](outline/outline#11198) - Document changes made through the API are now synced to clients in realtime in [#​11186](outline/outline#11186) - The rate limiter now prefers user ID over ip address for logged in sessions, prevents issues on larger office networks in [#​11215](outline/outline#11215) - The markdown importer now supports more file layouts in [#​11278](outline/outline#11278) ##### Fixes - Fixed some typos comments and messages by [@​NAM-MAN](https://github.com/NAM-MAN) in [#​11203](outline/outline#11203) - Fixed an issue where mentions would sometimes break when using drag and drop in a list in [#​11208](outline/outline#11208) - The edit diagram control no longer appears in read-only mode in [#​11207](outline/outline#11207) - Infinite recursion in `dd-trace` dependency causes memory issues in [#​11211](outline/outline#11211) - Imported content now gracefully handles HTTP links in [#​11210](outline/outline#11210) - Editor suggestions on mobile now uses a drawer in [#​11213](outline/outline#11213) - When importing markdown checkboxes are now supported in table cells in [#​11217](outline/outline#11217) - GCS uniform bucket-level access now supported by [@​maycuatroi1](https://github.com/maycuatroi1) in [#​11222](outline/outline#11222) - Fixed a hanging read stream handle causing excessive memory usage on export in [#​11237](outline/outline#11237) - Fixed mermaid diagrams do not render when pasting markdown in [#​11243](outline/outline#11243) - Remote edits no longer exit Mermaid editing state in [#​11244](outline/outline#11244) - Table row is now inserted correctly with merged first column cells in [#​11245](outline/outline#11245) - Allow http\:// loopback redirect URIs for native OAuth apps (RFC 8252) in [#​11255](outline/outline#11255) - "Split cell" option now works without accurate selection in [#​11256](outline/outline#11256) - Adding text below images is now easier as trailing paragraph is enforcedd by [@​RudraPrasad001](https://github.com/RudraPrasad001) in [#​11257](outline/outline#11257) - Tooltip in editor toolbar with submenu is now hidden when submenu is open in [#​11263](outline/outline#11263) - Non-platform passkeys such as Yubikey and mobile QRcode are now allowed in [#​11265](outline/outline#11265) - diagrams.net theme now matches editor theme by [@​Twometer](https://github.com/Twometer) in [#​11267](outline/outline#11267) - Custom emoji characters are now displayed correctly in TOC in [#​11275](outline/outline#11275) - Fixed an issue where the policy for documents restore was too broad in [#​11279](outline/outline#11279) - Passkey setup is now available to non-admin users by [@​Raphmatt](https://github.com/Raphmatt) in [#​11286](outline/outline#11286) ##### New Contributors - [@​NAM-MAN](https://github.com/NAM-MAN) made their first contribution in [#​11203](outline/outline#11203) - [@​lucawimmer](https://github.com/lucawimmer) made their first contribution in [#​11198](outline/outline#11198) - [@​maycuatroi1](https://github.com/maycuatroi1) made their first contribution in [#​11222](outline/outline#11222) - [@​RudraPrasad001](https://github.com/RudraPrasad001) made their first contribution in [#​11257](outline/outline#11257) - [@​Twometer](https://github.com/Twometer) made their first contribution in [#​11267](outline/outline#11267) - [@​Raphmatt](https://github.com/Raphmatt) made their first contribution in [#​11286](outline/outline#11286) **Full Changelog**: <outline/outline@v1.3.0...v1.4.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi42OS4yIiwidXBkYXRlZEluVmVyIjoiNDIuNjkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiaW1hZ2UiXX0=--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/3547 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
Table columns with dates were being sorted alphabetically instead of chronologically. For example, "01.01.2025" would sort before "08.04.2025" by chance, but not in the correct chronological order.
Solution
date-fnsfor common formats:yyyy-MM-dddd.MM.yyyy,dd/MM/yyyyMM/dd/yyyydd.MM.,dd/MM, etc.Behavior