Conversation
ostromart
added a commit
that referenced
this pull request
Apr 6, 2018
ostromart
pushed a commit
that referenced
this pull request
Jun 23, 2018
* # This is a combination of 5 commits. # This is the 1st commit message: update istio.io/api for new mcp definitions # This is the commit message #1: update mcp server # This is the commit message #2: update snapshot package # This is the commit message #3: use mcp service in galley/pkg/server # This is the commit message #4: fix linter * update istio.io/api for new mcp definitions update the latest mcp service definitions from istio.io/api * fix linter error (again?)
ostromart
pushed a commit
that referenced
this pull request
Aug 1, 2018
* Separate generated metadata into their own, top-level package: pkg/metadata - Introduce builder pattern to the core schema types that are used by pkg/metadata, to ensure runtime immutability after build. - Move the Kubernetes related machinery to their own package, pkg/kube/source, to separate it from core Kubernetes related abstractions and utility code. - Bolster tests and cleanup tests accordingly. * Add builder support to InMemory snapshot. (#3) * Add builder support to InMemory snapshot. * Clone resurces as well. * Use proto.Clone, instead of manual copying. * Add a testing server for MCP. (#4) * Add a testing server for MCP. * Add overridable port field. * Don't parse the port number. * Minor bug & linter fix (#6) * Fix a bug in the in-memory source implementation where the item itself was missing when publishing already-existing items during the initial sync phase. * Fix lint issue. * Updates to acommodate merge. * Update Gokg.lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bulk of this PR is generating v2.DiscoveryResponse for LDS. This comprises:
Unit testing is done by creating a new v2.DiscoveryServer with an embedded v1.DiscoveryServer. The reason for this is to avoid the circular dependency of including v2 functions in v1. v2 necessarily uses some v1 symbols (point 3 above) so v2 handling cannot be added directly to v1 at this time.