Skip to content

Use mcp grpc service definition instead of xds/ads#6491

Merged
istio-testing merged 3 commits intoistio:masterfrom
ayj:use-mcp-service
Jun 21, 2018
Merged

Use mcp grpc service definition instead of xds/ads#6491
istio-testing merged 3 commits intoistio:masterfrom
ayj:use-mcp-service

Conversation

@ayj
Copy link
Copy Markdown
Contributor

@ayj ayj commented Jun 21, 2018

Depends on istio/api#554 for gogoproto.equal_all option.

@istio-testing istio-testing requested review from hklai and qiwzhang June 21, 2018 20:40
@ayj ayj requested review from ozevren and removed request for hklai and qiwzhang June 21, 2018 20:40
@ozevren
Copy link
Copy Markdown
Contributor

ozevren commented Jun 21, 2018

/lgtm
/approve

ayj added 2 commits June 21, 2018 15:18
@ayj
# This is a combination of 5 commits.
e8e8a59 
# This is the 1st commit message:

update istio.io/api for new mcp definitions

# This is the commit message #1:

update mcp server

# This is the commit message #2:

update snapshot package

# This is the commit message #3:

use mcp service in galley/pkg/server

# This is the commit message #4:

fix linter
@ayj
update istio.io/api for new mcp definitions
791f227 
update the latest mcp service definitions from istio.io/api
@ayj ayj force-pushed the use-mcp-service branch from 374cde2 to 791f227 Compare June 21, 2018 22:20
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 21, 2018 •
edited
Loading

Codecov Report

Merging #6491 into master will decrease coverage by 1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #6491    +/-   ##
=======================================
- Coverage      69%     69%   -<1%     
=======================================
  Files         372     372            
  Lines       31822   31976   +154     
=======================================
+ Hits        21667   21757    +90     
- Misses       9301    9362    +61     
- Partials      854     857     +3
Impacted Files Coverage Δ
galley/pkg/mcp/snapshot/inmemory.go 100% <100%> (ø) ⬆️
galley/pkg/mcp/snapshot/snapshot.go 100% <100%> (+5%) ⬆️
galley/pkg/mcp/server/server.go 87% <100%> (+3%) ⬆️
galley/pkg/server/server.go 90% <100%> (ø) ⬆️
broker/pkg/controller/controller.go 34% <0%> (-5%) ⬇️
mixer/adapter/solarwinds/log_handler.go 54% <0%> (-4%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 64% <0%> (-4%) ⬇️
mixer/adapter/circonus/circonus.go 71% <0%> (-3%) ⬇️
mixer/adapter/opa/opa.go 79% <0%> (-1%) ⬇️
mixer/adapter/memquota/keys.go 100% <0%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f48da...c2f2fbe. Read the comment docs.

@ayj
Copy link
Copy Markdown
Contributor Author

ayj commented Jun 21, 2018

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jun 21, 2018

@ayj: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andraxylia
Copy link
Copy Markdown
Contributor

andraxylia commented Jun 21, 2018

/lgtm

@ayj ayj requested a review from geeknoid June 21, 2018 23:05
@geeknoid
Copy link
Copy Markdown
Contributor

geeknoid commented Jun 21, 2018

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jun 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andraxylia, ayj, geeknoid, ozevren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit acbde92 into istio:master Jun 21, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jun 22, 2018 •
edited
Loading

@ayj: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-dashboard.sh c2f2fbe link /test e2e-dashboard
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj ayj deleted the use-mcp-service branch October 17, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geeknoid geeknoid Awaiting requested review from geeknoid

2 more reviewers

@andraxylia andraxylia andraxylia approved these changes

@ozevren ozevren ozevren approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andraxylia andraxylia

@ozevren ozevren

@geeknoid geeknoid

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ayj @ozevren @istio-testing @andraxylia @geeknoid @googlebot