Skip to content

add missing gogoproto.equal_all option to mcp envelope and metadata#554

Merged
istio-testing merged 1 commit intoistio:masterfrom
ayj:add-equal_all-option-to-mcp-env-metadata
Jun 21, 2018
Merged

add missing gogoproto.equal_all option to mcp envelope and metadata#554
istio-testing merged 1 commit intoistio:masterfrom
ayj:add-equal_all-option-to-mcp-env-metadata

Conversation

@ayj
Copy link
Copy Markdown
Contributor

@ayj ayj commented Jun 21, 2018

@ayj ayj requested a review from geeknoid June 21, 2018 20:25
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jun 21, 2018
@ozevren
Copy link
Copy Markdown
Contributor

ozevren commented Jun 21, 2018

/lgtm

Copy link
Copy Markdown
Contributor

@geeknoid geeknoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayj, geeknoid, ozevren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 5c19bec into istio:master Jun 21, 2018
@ayj ayj deleted the add-equal_all-option-to-mcp-env-metadata branch June 21, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants