Skip to content

sdformat15: support multiple python versions#2836

Merged
scpeters merged 9 commits intomasterfrom
ci_matching_branch/build_python_bindings_separately
Nov 5, 2024
Merged

sdformat15: support multiple python versions#2836
scpeters merged 9 commits intomasterfrom
ci_matching_branch/build_python_bindings_separately

Conversation

@scpeters
Copy link
Copy Markdown
Member

Part of #2834. Build bindings for both python@3.12 and python@3.13.

The following is a test of this branch, that only fails because of a brew audit error, which I am discussing with homebrew maintainers in Homebrew/brew#18552:

Test: Build Status https://build.osrfoundation.org/view/gz-ionic/job/gz_math8-install_bottle-homebrew-amd64/303/

Build bindings for both python@3.12 and python@3.13.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
It is not recommended by brew to mix runtime and
non-runtime dependencies on python versions, so follow
that pattern. This means that `brew install gz-math8`
won't install python, but our documentation instructs
users to `brew install python` anyway, so this is fine.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Copy Markdown
Member Author

that only fails because of a brew audit error, which I am discussing with homebrew maintainers in Homebrew/brew#18552

After discussion, I've decided to replace depends_on "python@3.X" with multiple depends_on "python@3.X" => [:build, :test] (ccda476), which is a pattern that passes brew audit. The main change is that brew install gz-math8 won't also install a brew version of python, but our documentation already instructs our users to do that, so I think it's ok.

Testing again:

Build bindings for both python@3.12 and python@3.13.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Copy Markdown
Member Author

see #2839 for gz-math8 changes

@scpeters scpeters changed the title gz-math8: support multiple python versions sdformat15: support multiple python versions Oct 29, 2024
@scpeters scpeters marked this pull request as ready for review November 5, 2024 21:32
@scpeters
Copy link
Copy Markdown
Member Author

scpeters commented Nov 5, 2024

build bottle

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Copy Markdown
Member Author

scpeters commented Nov 5, 2024

build bottle

@scpeters scpeters merged commit 71c92e0 into master Nov 5, 2024
@scpeters scpeters deleted the ci_matching_branch/build_python_bindings_separately branch November 5, 2024 22:42
scpeters added a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants