PythonVersions audit: test mixed runtime dependencies#18552
PythonVersions audit: test mixed runtime dependencies#18552scpeters wants to merge 1 commit intoHomebrew:masterfrom
Conversation
The PythonVersions cop currently complains if a formula depends on a mixed combination of runtime and non-runtime python versions. This adds a test to demonstrate the behavior.
|
I had an old PR on this where general opinion was against: #16119 EDIT: Though if the usage is only 3rd party tap, it could be up for discussion on whether some checks could be made core only. |
I'd be fine with this 👍🏻 |
|
I've thought about it, and I'll switch our formulae
thanks for the reference to the prior discussion here. In the short-term, I'll just use
thanks for the feedback. For now I will close this since I'm not planning to work on it immediately, but I will come back to it if it seems useful to our users |
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?I have been updating a formula in a 3rd-party tap that currently has a runtime dependency on
python@3.12(no:buildor:testannotations), and I'd like to update it to depend on multiple python versions in order to build bindings against multiple versions but still depend on one version as a runtime dependency, like the following:The PythonVersions audit currently complains about this:
If there isn't a problem with depending on a mix of runtime and non-runtime versions of python, I'd like to update the audit to allow this. I've opened this as a draft PR with a failing test that should pass once the audit is updated. Please let me know if this obviously won't be accepted before I spend time to try to update the audit.