meta: automatically allow devices as input in the stages schemas#1727
Merged
mvo5 merged 1 commit intoosbuild:mainfrom Apr 16, 2024
Merged
meta: automatically allow devices as input in the stages schemas#1727mvo5 merged 1 commit intoosbuild:mainfrom
devices as input in the stages schemas#1727mvo5 merged 1 commit intoosbuild:mainfrom
Conversation
supakeen
reviewed
Apr 15, 2024
achilleas-k
previously approved these changes
Apr 15, 2024
With the new `bootc install to-filesystem` support many stages will need a devices/mount setup to bind mount the deployment root from the bootc deployment root of the generated image. To make this globally available just allow "devices/mounts" for all stages in the schema validation. Note that `mounts` is already globally allowed so this just adds devices (this was added in `7e776a076` with ostree as the use-case). Nothing will change for the filesystem stages that already define "devices" in a more specialized way.
287dfe9 to
3ed11f9
Compare
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Apr 15, 2024
With the new uniform way to handle writing to the bootc image deployment we can now support a custom `/etc/fstab` again. Similar to what we do for users [0] and groups [1] we allow also writing a custom fstab now. This will need osbuild/osbuild#1727 and also probably a port of the fstab module to schema_2. [0] osbuild#571 [1] osbuild#593
achilleas-k
approved these changes
Apr 15, 2024
supakeen
approved these changes
Apr 15, 2024
github-merge-queue bot
pushed a commit
to osbuild/images
that referenced
this pull request
Apr 16, 2024
With the new uniform way to handle writing to the bootc image deployment we can now support a custom `/etc/fstab` again. Similar to what we do for users [0] and groups [1] we allow also writing a custom fstab now. This will need osbuild/osbuild#1727 and also probably a port of the fstab module to schema_2. [0] #571 [1] #593
github-merge-queue bot
pushed a commit
to osbuild/images
that referenced
this pull request
Apr 16, 2024
With the new uniform way to handle writing to the bootc image deployment we can now support a custom `/etc/fstab` again. Similar to what we do for users [0] and groups [1] we allow also writing a custom fstab now. This will need osbuild/osbuild#1727 and also probably a port of the fstab module to schema_2. [0] #571 [1] #593
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[as suggested in https://github.com//pull/1726#pullrequestreview-2000367493]
[edit: note that if we merge this we should simplify org.osbuild.{selinux,users,groups}.meta.json to remove the now redudant/identical schemas for devices/mounts]
With the new
bootc install to-filesystemsupport many stages will need a devices/mount setup to bind mount the deployment root from the bootc deployment root of the generated image. To make this globally available just allow "devices/mounts" for all stages in the schema validation.Note that
mountsis already globally allowed so this just adds devices (this was added in7e776a076with ostree as the use-case). Nothing will change for the filesystem stages that already define "devices" in a more specialized way.