stages(groups): add support for the mounts for bootc install to-filesystem #1726
Merged
ondrejbudai merged 2 commits intoosbuild:mainfrom Apr 15, 2024
Merged
stages(groups): add support for the mounts for bootc install to-filesystem #1726ondrejbudai merged 2 commits intoosbuild:mainfrom
bootc install to-filesystem #1726ondrejbudai merged 2 commits intoosbuild:mainfrom
Conversation
The schema will move to v2 so we need to ensure that at least some minimal validation is done that the old and the new schema work the same way.
This will allow us to generate `bootc install to-filesystem` compatible devices/mount setups for the groups stage.
bootc install to-filesystem
ondrejbudai
approved these changes
Apr 15, 2024
Member
ondrejbudai
left a comment
There was a problem hiding this comment.
Looks good! :) I'm still generally of favor of just allowing devices/mounts globally, but let's think about that when we have more time.
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Apr 15, 2024
When porting custoizations to the new `bootc install to-filesystem` world initially only users/kernel-options where added. This commit adds `org.osbuild.groups` now as well. Needs: osbuild#571 osbuild/osbuild#1726
This was referenced Apr 15, 2024
Contributor
Author
Sure, I opened #1727 |
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Apr 15, 2024
When porting custoizations to the new `bootc install to-filesystem` world initially only users/kernel-options where added. This commit adds `org.osbuild.groups` now as well. Needs: osbuild#571 osbuild/osbuild#1726
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Apr 15, 2024
When porting custoizations to the new `bootc install to-filesystem` world initially only users/kernel-options where added. This commit adds `org.osbuild.groups` now as well. Needs: osbuild#571 osbuild/osbuild#1726
achilleas-k
pushed a commit
to mvo5/images
that referenced
this pull request
Apr 15, 2024
When porting custoizations to the new `bootc install to-filesystem` world initially only users/kernel-options where added. This commit adds `org.osbuild.groups` now as well. Needs: osbuild#571 osbuild/osbuild#1726
achilleas-k
approved these changes
Apr 15, 2024
Member
achilleas-k
left a comment
There was a problem hiding this comment.
Even if we don't need the devices and mounts in the end (#1727), it's good to have v2 schemas in general, so let's merge this.
github-merge-queue bot
pushed a commit
to osbuild/images
that referenced
this pull request
Apr 15, 2024
When porting custoizations to the new `bootc install to-filesystem` world initially only users/kernel-options where added. This commit adds `org.osbuild.groups` now as well. Needs: #571 osbuild/osbuild#1726
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to generate
bootc install to-filesystemcompatible devices/mount setups for the groups stage.